cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tony Homer (JIRA)" <>
Subject [jira] [Commented] (CB-9145) prepare can lose data during config munge
Date Tue, 09 Jun 2015 15:26:00 GMT


Tony Homer commented on CB-9145:

It looks like the logic for detecting exact matches was added here:

I have a preliminary fix for this; I do a 2-way comparison instead of the existing one way

Tests were added at same time as the "exact match logic", so I should be able to adapt one
of them to test for this case.
Looking into that now.

> prepare can lose data during config munge
> -----------------------------------------
>                 Key: CB-9145
>                 URL:
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: CordovaLib
>    Affects Versions: Master
>            Reporter: Tony Homer
> If a node is added to config.xml with same name and matching attributes as an existing
node, but it is missing attributes, it is treated as an exact match during config munge and
is not added to platform config.xml.  For example, when the following tags are present in
www/config.xml, then second tag will not be added to platforms/android/res/xml/config.xml:
> {code}
> <access origin="*" launch-external="yes"/>
> <access origin="*" />
> {code}
> AFAIK, this is most important for access tags, but will affect any tag where it is possible
for one tag to be a subset of another tag.

This message was sent by Atlassian JIRA

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message