cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-9126) Fix ios pbxproj' resources paths when adding ios platform on non-OSX environment
Date Fri, 05 Jun 2015 16:22:03 GMT

    [ https://issues.apache.org/jira/browse/CB-9126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14574770#comment-14574770
] 

ASF GitHub Bot commented on CB-9126:
------------------------------------

GitHub user daserge opened a pull request:

    https://github.com/apache/cordova-lib/pull/237

    CB-9126 Fix ios pbxproj' resources paths when adding ios platform on non-OSX environment

    [Jira issue with details](https://issues.apache.org/jira/browse/CB-9126)

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/MSOpenTech/cordova-lib CB-9126

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-lib/pull/237.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #237
    
----
commit 1df2053918cbceefc409edc35cd0d363efd34536
Author: daserge <daserge@yandex.ru>
Date:   2015-06-05T16:16:49Z

    CB-9126 Fix ios pbxproj' resources paths when adding ios platform on non-OSX environment

----


> Fix ios pbxproj' resources paths when adding ios platform on non-OSX environment
> --------------------------------------------------------------------------------
>
>                 Key: CB-9126
>                 URL: https://issues.apache.org/jira/browse/CB-9126
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: iOS
>            Reporter: Sergey Shakhnazarov
>
> Adding ios platform on Windows causes such build error on OSX:
> CpResource mobilespec/Resources/ResourcesCDVNotification.bundle build/emulator/mobilespec.app/ResourcesCDVNotification.bundle
> cd /Users/admin/Desktop/cordova5/mobilespec3/platforms/ios
> export PATH="/Applications/Xcode.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/usr/bin:/Applications/Xcode.app/Contents/Developer/usr/bin:/usr/local/bin:/usr/bin:/bin:/usr/sbin:/sbin"
> builtin-copy -exclude .DS_Store -exclude CVS -exclude .svn -exclude .git -exclude .hg
-resolve-src-symlinks /Users/admin/Desktop/cordova5/mobilespec3/platforms/ios/mobilespec/Resources/ResourcesCDVNotification.bundle
/Users/admin/Desktop/cordova5/mobilespec3/platforms/ios/build/emulator/mobilespec.app
> error: /Users/admin/Desktop/cordova5/mobilespec3/platforms/ios/mobilespec/Resources/ResourcesCDVNotification.bundle:
No such file or directory
> This is caused by [this node-xcode' code|https://github.com/alunny/node-xcode/blob/ff9f67a543f5ec91988e06937b0f73e23ac38a9e/lib/pbxProject.js#L707]:
> {code:javascript}
>     var r_resources_dir = /^Resources\//;
>     if (project.pbxGroupByName('Resources').path)
>         file.path = file.path.replace(r_resources_dir, '');
>     ...
> {code}
> The regexp does not take backslash into account - this is [fixed in node-xcode current
version (0.7.0)|https://github.com/alunny/node-xcode/blob/a8f8e25780700716cefdc0e43da4d755f80f51b2/lib/pbxProject.js#L766].



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message