cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-9121) Add support for build configuration to be specified using the CLI
Date Fri, 05 Jun 2015 19:37:00 GMT

    [ https://issues.apache.org/jira/browse/CB-9121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14575075#comment-14575075
] 

ASF GitHub Bot commented on CB-9121:
------------------------------------

Github user omefire commented on a diff in the pull request:

    https://github.com/apache/cordova-cli/pull/215#discussion_r31844480
  
    --- Diff: src/cli.js ---
    @@ -226,7 +227,9 @@ function cli(inputArgs) {
                     downstreamArgs.push('--' + flag);
                 }
             });
    -
    +        if (args.buildConfig) {
    +            downstreamArgs.push('--buildConfig=' + args.buildConfig);
    --- End diff --
    
    ok, never mind. it seems like cordova-lib just passes the --buildConfig args to the underlying
platform, which does the bulk of the work : https://github.com/apache/cordova-android/pull/164



> Add support for build configuration to be specified using the CLI
> -----------------------------------------------------------------
>
>                 Key: CB-9121
>                 URL: https://issues.apache.org/jira/browse/CB-9121
>             Project: Apache Cordova
>          Issue Type: Improvement
>          Components: CLI
>    Affects Versions: 5.2
>            Reporter: Nikhil Khandelwal
>            Assignee: Nikhil Khandelwal
>            Priority: Minor
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message