cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-9119) ADB install in automation sometimes hangs the emulator
Date Wed, 10 Jun 2015 06:23:01 GMT

    [ https://issues.apache.org/jira/browse/CB-9119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14580096#comment-14580096
] 

ASF GitHub Bot commented on CB-9119:
------------------------------------

Github user dblotsky commented on a diff in the pull request:

    https://github.com/apache/cordova-android/pull/180#discussion_r32090950
  
    --- Diff: bin/templates/cordova/lib/exec.js ---
    @@ -19,16 +19,42 @@
            under the License.
     */
     
    -var child_process = require('child_process'),
    -    Q       = require('q');
    +var child_process = require('child_process');
    +var Q             = require('q');
    +
    +// constants
    +var DEFAULT_MAX_BUFFER = 1024000;
     
     // Takes a command and optional current working directory.
     // Returns a promise that either resolves with the stdout, or
     // rejects with an error message and the stderr.
    -module.exports = function(cmd, opt_cwd) {
    +//
    +// WARNING:
    +//         opt_cwd is an artifact of an old design, and must
    +//         be removed in the future; the correct solution is
    +//         to pass the options object the same way that
    +//         child_process.exec expects
    +//
    +// NOTE:
    +//      exec documented here - https://nodejs.org/api/child_process.html#child_process_child_process_exec_command_options_callback
    +module.exports = function(cmd, opt_cwd, options) {
    +
         var d = Q.defer();
    +
    +    if (options === undefined) {
    +        options = {};
    +    }
    +
    +    // override cwd to preserve old opt_cwd behavior
    +    options.cwd = opt_cwd;
    +
    +    // set maxBuffer
    +    if (options.maxBuffer === undefined) {
    --- End diff --
    
    Now using `typeof options.maxBuffer === "undefined"` instead.


> ADB install in automation sometimes hangs the emulator
> ------------------------------------------------------
>
>                 Key: CB-9119
>                 URL: https://issues.apache.org/jira/browse/CB-9119
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: Android
>    Affects Versions: Master
>            Reporter: Dmitry Blotsky
>            Assignee: Dmitry Blotsky
>            Priority: Critical
>              Labels: adb, android, hang, hard_to_verify
>   Original Estimate: 72h
>  Remaining Estimate: 72h
>
> Sometimes "adb install ..." hangs indefinitely when running "cordova run" under medic.
Jenkins also sees this. Related links below.
> Android bug: http://code.google.com/p/android/issues/detail?id=10255



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message