cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-9119) ADB install in automation sometimes hangs the emulator
Date Tue, 09 Jun 2015 02:09:00 GMT

    [ https://issues.apache.org/jira/browse/CB-9119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14578197#comment-14578197
] 

ASF GitHub Bot commented on CB-9119:
------------------------------------

Github user dblotsky commented on a diff in the pull request:

    https://github.com/apache/cordova-android/pull/180#discussion_r31977946
  
    --- Diff: bin/templates/cordova/lib/retry.js ---
    @@ -0,0 +1,63 @@
    +#!/usr/bin/env node
    +
    +/*
    +    Licensed to the Apache Software Foundation (ASF) under one
    +    or more contributor license agreements.  See the NOTICE file
    +    distributed with this work for additional information
    +    regarding copyright ownership.  The ASF licenses this file
    +    to you under the Apache License, Version 2.0 (the
    +    "License"); you may not use this file except in compliance
    +    with the License.  You may obtain a copy of the License at
    +
    +      http://www.apache.org/licenses/LICENSE-2.0
    +
    +    Unless required by applicable law or agreed to in writing,
    +    software distributed under the License is distributed on an
    +    "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    +    KIND, either express or implied.  See the License for the
    +    specific language governing permissions and limitations
    +    under the License.
    +*/
    +
    +/* jshint node: true */
    +
    +"use strict";
    +
    +/*
    + * Retry a promise-returning function attemts_left times, propagating its
    + * results on success or throwing its error on a failed final attempt.
    + *
    + * Takes a number of attempts, a promise-returning function, and all its
    + * arguments (as trailing arguments).
    + */
    +module.exports.retryPromise = function (attemts_left, promiseFunction) {
    +
    +    // NOTE:
    +    //      get all trailing arguments, by skipping the first two (attemts_left and
    +    //      promiseFunction) because they shouldn't get passed to promiseFunction
    +    var promiseFunctionArguments = Array.prototype.slice.call(arguments, 2);
    +
    +    return promiseFunction.apply(undefined, promiseFunctionArguments).then(
    +
    +        // on success pass results through
    +        function onFulfilled(value) {
    +            return value;
    +        },
    +
    +        // on rejection either retry, or throw the error
    +        function onRejected(error) {
    +
    +            attemts_left -= 1;
    +
    +            if (attemts_left < 1) {
    +                throw error;
    +            }
    +
    +            console.log("call failed; retrying " + attemts_left + " more time(s)");
    --- End diff --
    
    I'm conflicted on whether this log message should exist. It's there now because I chose
to be more verbose rather than less verbose, but I'm not sure that it belongs here in general.
If this function gets used in other places, these messages will quickly get out of hand. What's
Cordova's way to print verbose logs only when asked?


> ADB install in automation sometimes hangs the emulator
> ------------------------------------------------------
>
>                 Key: CB-9119
>                 URL: https://issues.apache.org/jira/browse/CB-9119
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: Android
>    Affects Versions: Master
>            Reporter: Dmitry Blotsky
>            Assignee: Dmitry Blotsky
>            Priority: Critical
>              Labels: adb, android, hang, hard_to_verify
>   Original Estimate: 72h
>  Remaining Estimate: 72h
>
> Sometimes "adb install ..." hangs indefinitely when running "cordova run" under medic.
Jenkins also sees this. Related links below.
> Android bug: http://code.google.com/p/android/issues/detail?id=10255



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message