cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF subversion and git services (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-9115) Lollipop onPermissionRequest denies everything
Date Wed, 10 Jun 2015 18:54:01 GMT

    [ https://issues.apache.org/jira/browse/CB-9115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14580949#comment-14580949
] 

ASF subversion and git services commented on CB-9115:
-----------------------------------------------------

Commit eb70f05168dcf3a07d8716c772db3a3c3c3a59f8 in cordova-android's branch refs/heads/master
from [~vfbraun]
[ https://git-wip-us.apache.org/repos/asf?p=cordova-android.git;h=eb70f05 ]

CB-9115 android: Grant Lollipop permission req

This patch overrides onPermissionRequest so that getUserMedia can be
used inside the browser.

Since a hybrid app has to request permissions anyways via
AndroidManifest.xml, I think it is unnecessary to have any further
configuration for onPermissionRequest. Anything that the app is allowed
to do should be possible from the JS side. Hence all requests are
granted. This enables getUserMedia (and WebRTC) on Android Lollipop,
without resorting to crosswalk.

The docs say that request.grant has to be called from the UI thread, but
don't explicitly spell out whether onPermissionRequest is called from
the UI thread. I think that this is so, the WebChromeClient of course
makes its calls from the UI thread unless otherwise noted. So there is
no need to post a runnable to the UI thread.

This closes 178
https://github.com/apache/cordova-android/pull/178


> Lollipop onPermissionRequest denies everything
> ----------------------------------------------
>
>                 Key: CB-9115
>                 URL: https://issues.apache.org/jira/browse/CB-9115
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: Android
>    Affects Versions: Master
>         Environment: Android L
>            Reporter: Volker Braun
>            Assignee: Joe Bowser
>
> WebChromeClient.onPermissionRequest is not overridden, so getUserMedia permission requests
are denied by default.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message