Return-Path: X-Original-To: apmail-cordova-issues-archive@minotaur.apache.org Delivered-To: apmail-cordova-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id D986E1807F for ; Thu, 21 May 2015 18:13:17 +0000 (UTC) Received: (qmail 33737 invoked by uid 500); 21 May 2015 18:13:17 -0000 Delivered-To: apmail-cordova-issues-archive@cordova.apache.org Received: (qmail 33715 invoked by uid 500); 21 May 2015 18:13:17 -0000 Mailing-List: contact issues-help@cordova.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@cordova.apache.org Received: (qmail 33694 invoked by uid 99); 21 May 2015 18:13:17 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 21 May 2015 18:13:17 +0000 Date: Thu, 21 May 2015 18:13:17 +0000 (UTC) From: "ASF subversion and git services (JIRA)" To: issues@cordova.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (CB-9025) Call platform-specific 'prepare' logic on windows as part of the 'prepare' step MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/CB-9025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14554775#comment-14554775 ] ASF subversion and git services commented on CB-9025: ----------------------------------------------------- Commit 53c5939816885479a952c30622d89d9ddfbac614 in cordova-windows's branch refs/heads/master from [~vladimir.kotikov] [ https://git-wip-us.apache.org/repos/asf?p=cordova-windows.git;h=53c5939 ] CB-9025 Removes 'prepare' logic call as part of the 'build'. > Call platform-specific 'prepare' logic on windows as part of the 'prepare' step > ------------------------------------------------------------------------------- > > Key: CB-9025 > URL: https://issues.apache.org/jira/browse/CB-9025 > Project: Apache Cordova > Issue Type: Task > Components: CordovaLib, Windows > Reporter: Vladimir Kotikov > Assignee: Vladimir Kotikov > > All of the 'prepare' logic of windows is called as part of build and this makes other tools and hooks to plug in correctly difficult. > The proposed approach is to require and execute this logic inside of cordova-lib {{prepare}} method like this is done for android here: https://github.com/apache/cordova-lib/blob/master/cordova-lib/src/plugman/install.js#L565 > However, to avoid this logic to be called twice (from cordova-lib {{prepare}} and platfrom's {{build}}) we need to remove {{applyPlatformConfig}} call from build script. -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org For additional commands, e-mail: issues-help@cordova.apache.org