cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andrew Grieve (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-9061) [Android] shouldAllowNavigation() is evaluated before shouldOpenExternalUrl() in CordovaWebViewImpl.onNavigationAttempt()
Date Fri, 22 May 2015 21:26:18 GMT

    [ https://issues.apache.org/jira/browse/CB-9061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14556854#comment-14556854
] 

Andrew Grieve commented on CB-9061:
-----------------------------------

Seems like what we'd want here instead is a way to explicitly open a page in the system browser
rather than link-clicking detecting it. 

If the precedence was reversed then someone could have the reverse problem just as easily
(a page loading in system browser rather than webview).

> [Android] shouldAllowNavigation() is evaluated before shouldOpenExternalUrl() in CordovaWebViewImpl.onNavigationAttempt()
> -------------------------------------------------------------------------------------------------------------------------
>
>                 Key: CB-9061
>                 URL: https://issues.apache.org/jira/browse/CB-9061
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: Android
>    Affects Versions: 4.0.0
>            Reporter: Maurus Cuelenaere
>         Attachments: patch.diff
>
>
> shouldAllowNavigation() takes precedence over shouldOpenExternalUrl() in org.apache.cordova.CordovaWebViewImpl.onNavigationAttempt(),
making it impossible to launch an external browser for a specific URL pattern when a less
specific pattern is allowed for navigation.
> Example config:
> {code}
> <allow-navigation href="*://example.com/*" />
> <allow-intent href="*://example.com/out/*" />
> {code}
> Navigating to http://example.com/out/foobar doesn't trigger an intent for an external
browser.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message