cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF subversion and git services (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-9051) Plugins don't get re-added if platforms folder deleted
Date Fri, 22 May 2015 01:15:17 GMT

    [ https://issues.apache.org/jira/browse/CB-9051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14555411#comment-14555411
] 

ASF subversion and git services commented on CB-9051:
-----------------------------------------------------

Commit bddcc8f2d709a55df2d91c14def61212843a14e8 in cordova-lib's branch refs/heads/master
from [~TimBarham]
[ https://git-wip-us.apache.org/repos/asf?p=cordova-lib.git;h=bddcc8f ]

CB-9051 Plugins don't get re-added if platforms folder deleted.

To avoid attempting to add a plugin twice while adding a platform (a scenario that can occur
now with automatic restore of plugins and platforms), when adding plugins to a newly added
platform we check to see if the plugin has already been added by calling plugman's PlatformJson.isPluginInstalled(),
which looks in plugins/<platform>.json to see if the plugin has been installed for a
platform.

If you delete a platform's folder, it's plugins/<platform>.json file still exists, so
if you add the platform again, we think all plugins are already installed for it and so don't
try to install them.

Simple fix is to delete the platform's plugins/<platform>.json file before adding a
platform, so we start with a clean slate.


> Plugins don't get re-added if platforms folder deleted
> ------------------------------------------------------
>
>                 Key: CB-9051
>                 URL: https://issues.apache.org/jira/browse/CB-9051
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: CordovaLib, Plugman
>    Affects Versions: 5.0.0
>            Reporter: Tim Barham
>            Assignee: Tim Barham
>   Original Estimate: 2h
>  Remaining Estimate: 2h
>
> If you add a platform, the delete the platforms folder (or just the folder for that specific
platform), then add the platform again, no plugins are installed for that platform.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message