cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-9025) Call platform-specific 'prepare' logic on windows as part of the 'prepare' step
Date Thu, 21 May 2015 19:03:19 GMT

    [ https://issues.apache.org/jira/browse/CB-9025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14554875#comment-14554875
] 

ASF GitHub Bot commented on CB-9025:
------------------------------------

Github user vladimir-kotikov closed the pull request at:

    https://github.com/apache/cordova-windows/pull/77


> Call platform-specific 'prepare' logic on windows as part of the 'prepare' step
> -------------------------------------------------------------------------------
>
>                 Key: CB-9025
>                 URL: https://issues.apache.org/jira/browse/CB-9025
>             Project: Apache Cordova
>          Issue Type: Task
>          Components: CordovaLib, Windows
>            Reporter: Vladimir Kotikov
>            Assignee: Vladimir Kotikov
>
> All of the 'prepare' logic of windows is called as part of build and this makes other
tools and hooks to plug in correctly difficult.
> The proposed approach is to require and execute this logic inside of cordova-lib {{prepare}}
method like this is done for android here: https://github.com/apache/cordova-lib/blob/master/cordova-lib/src/plugman/install.js#L565

> However, to avoid this logic to be called twice (from cordova-lib {{prepare}} and platfrom's
{{build}}) we need to remove {{applyPlatformConfig}} call from build script.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message