cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-8992) Mobile spec's createmobilespec always installs cordova-plugin-mobilespec-tests
Date Fri, 08 May 2015 22:26:03 GMT

    [ https://issues.apache.org/jira/browse/CB-8992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14535761#comment-14535761
] 

ASF GitHub Bot commented on CB-8992:
------------------------------------

Github user dblotsky commented on a diff in the pull request:

    https://github.com/apache/cordova-mobile-spec/pull/128#discussion_r29981911
  
    --- Diff: createmobilespec/createmobilespec.js ---
    @@ -546,11 +547,12 @@ function installPlugins() {
             console.log("Installing local test framework plugins...");
             var linkPluginsFlag = (argv.link || argv.linkplugins) ? ' --link' : '';
     
    -        pluginAdd('org.apache.cordova.mobilespec.tests', mobile_spec_git_dir, linkPluginsFlag
+ browserifyFlag);
    +        if (!argv.plugins) {
    --- End diff --
    
    Please comment why this check is here.


> Mobile spec's createmobilespec always installs cordova-plugin-mobilespec-tests
> ------------------------------------------------------------------------------
>
>                 Key: CB-8992
>                 URL: https://issues.apache.org/jira/browse/CB-8992
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: mobile-spec
>            Reporter: Alexander Sorokin
>            Priority: Minor
>
> Createmobilespec installs cordova-plugin-mobilespec-tests even when --plugins flag is
present, which is used to explicitly specify list of plugins to install.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message