cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-8879) [Windows] Camera picture has black/green stripes that crop image
Date Tue, 12 May 2015 23:27:00 GMT

    [ https://issues.apache.org/jira/browse/CB-8879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14540999#comment-14540999
] 

ASF GitHub Bot commented on CB-8879:
------------------------------------

GitHub user muratsu opened a pull request:

    https://github.com/apache/cordova-plugin-camera/pull/94

    CB-8879 fix stripe issue with correct aspect ratio

    This fixes the stripe issue we had on windows phone 8+. 
    The fix was to set up resolutions with a common aspect ratio. Default aspect ratio is
1.78 (hd). 

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/MSOpenTech/cordova-plugin-camera CB-8879

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-camera/pull/94.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #94
    
----
commit 4710faa91d86e46df1d66c24080b55cd8d86d459
Author: Murat Sutunc <sutunc@gmail.com>
Date:   2015-05-12T00:09:43Z

    CB-8879 fix stripe issue with correct aspect ratio

----


> [Windows] Camera picture has black/green stripes that crop image
> ----------------------------------------------------------------
>
>                 Key: CB-8879
>                 URL: https://issues.apache.org/jira/browse/CB-8879
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: Plugin Camera
>    Affects Versions: 3.6.0
>         Environment: windows
>            Reporter: Olivier VERMONT
>            Assignee: Murat Sutunc
>              Labels: camera, resolution, stripes, windows-phone-81
>
> When a photo is taken with Windows Phone 8.1 device Nokia Lumia 735, the picture returned
shows black or green stripes on the sides and is out of shape. It seems this is related to
photo resolution but I can't get it fixed in JS.
> It seems to be quite a common problem with the Media Capture API and people solved issue
in C# here is an illustration : http://stackoverflow.com/questions/23709547/captured-photo-with-stripes
> Here is what I tried without success :
> var resolutions = capture.videoDeviceController.getAvailableMediaStreamProperties(Windows.Media.Capture.MediaStreamType.photo);
> var maxWidth = 0;
> var maxResolution = null;
> for(var i=0; i<resolutions.length; i++){
> 	//console.log(resolutions[i].width);
> 	if(resolutions[i].width > maxResolution){
> 		maxWidth = resolutions[i].width;
> 		maxResolution = resolutions[i];
> 	}
> }					
> capture.videoDeviceController.setMediaStreamPropertiesAsync(Windows.Media.Capture.MediaStreamType.photo,
maxResolution)
> Am I missing something ?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message