cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-3562) Wrong splash screen ratio for landscape-only applications
Date Fri, 08 May 2015 00:41:00 GMT

    [ https://issues.apache.org/jira/browse/CB-3562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14533681#comment-14533681
] 

ASF GitHub Bot commented on CB-3562:
------------------------------------

GitHub user dpolivy opened a pull request:

    https://github.com/apache/cordova-plugin-splashscreen/pull/47

    CB-3562: Disable screen rotation for iPhone when splash screen is shown (updated)

    This is an updated port of emarashliev's fix for CB-3562, as this bug still exists. The
original PR #14 seems to be dead, however. I ported these changes over to the latest branch
of the plugin, and made some minor adjustments to avoid deprecated functions.
    
    @shazron @agrieve Given the discussion in the previous PR, hopefully this can be reviewed
and incorporated quickly.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/dpolivy/cordova-plugin-splashscreen CB3562

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-splashscreen/pull/47.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #47
    
----
commit 545b0a81139dd48accc4c25ccc8c8b2052635928
Author: Emil Marashliev <emarashliev@me.com>
Date:   2014-02-19T14:05:34Z

    CB-3562 Disable screen rotation for iPhone when splash screen is shown.

commit b6e3023f31063f4d6204355e6b13c348180cf603
Author: Dan Polivy <dan@cellartracker.com>
Date:   2015-05-08T00:35:10Z

    CB-3562: Disable screen rotation for iPhone when splash screen is shown.
    
    This is a port of emarashliev's original fix for CB-3562, cleaned up
    to avoid deprecated functions.
    
    Merge branch 'master' of https://github.com/emarashliev/cordova-plugin-splashscreen into
CB3562

----


> Wrong splash screen ratio for landscape-only applications
> ---------------------------------------------------------
>
>                 Key: CB-3562
>                 URL: https://issues.apache.org/jira/browse/CB-3562
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: iOS, Plugin SplashScreen
>    Affects Versions: 2.6.0, 2.7.0, 2.9.0
>            Reporter: Michael Hanselmann
>            Assignee: Shazron Abdullah
>             Fix For: 3.4.0
>
>
> CDVSplashScreen.m shows the splash image with a wrong ratio for landscape-only applications
on iPhone/iPod touch devices. I fixed it locally by applying a 90° transformation (“CGAffineTransformMakeRotation(M_PI
/ 2)”) to the image view.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message