Mailing-List: contact issues-help@cordova.apache.org; run by ezmlm
Precedence: bulk
Date: Thu, 9 Apr 2015 22:29:12 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: issues@cordova.apache.org
Message-ID: <JIRA.12818740.1428361310000.46640.1428618552416@Atlassian.JIRA>
In-Reply-To: <JIRA.12818740.1428361310000@Atlassian.JIRA>
References: <JIRA.12818740.1428361310000@Atlassian.JIRA>
 <JIRA.12818740.1428361310922@arcas>
Subject: [jira] [Commented] (CB-8803) Medic builds sometimes fail cleanup on
 Windows
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/CB-8803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14488405#comment-14488405 ] 

ASF GitHub Bot commented on CB-8803:
------------------------------------

Github user dblotsky commented on a diff in the pull request:

    https://github.com/apache/cordova-medic/pull/40#discussion_r28109060
  
    --- Diff: buildbot-conf/cordova.conf ---
    @@ -229,6 +229,8 @@ plugins_cleanup_steps = [
         NPMInstall(command=['shelljs'], what='shelljs'),
         RMRF('~/.cordova/*', description='removing cache', haltOnFailure=False),
         RMRF(BASE_WORKDIR + '/*', description='cleaning workspace', haltOnFailure=False),
    +    RMRF(BASE_WORKDIR + '/*', description='cleaning workspace again', haltOnFailure=False),
    +    RMRF(BASE_WORKDIR + '/*', description='cleaning workspace yet again', haltOnFailure=True),
    --- End diff --
    
    The solid solution, and hence the "proper fix", is to offload this work to a custom cleanup script. We currently have a chicken-and-egg problem because we need to download the script before we clean up, and then clean it up using itself. In the near future we should consolidate the medic scripts into an executable called `medic` that is not part of the downloaded repositories, and we will be able to clean up by calling something like:
    
        medic clean
        medic update_config
        medic build windows
    
    This will move a lot of logic out of buildbot, and it will also make the automated build tools more usable outside of buildbot.
    
    For now, the three steps are a very simple effective fix for the intermittent problem.


> Medic builds sometimes fail cleanup on Windows
> ----------------------------------------------
>
>                 Key: CB-8803
>                 URL: https://issues.apache.org/jira/browse/CB-8803
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: Medic, Windows
>    Affects Versions: Master
>         Environment: Any cordova-medic setup on Windows.
>            Reporter: Dmitry Blotsky
>            Priority: Minor
>              Labels: medic, rm, windows
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> On Windows, sometimes the cleanup step fails because of some stray process briefly looking at a directory while the directory is being deleted.
> Although medic uses shelljs's implementation of {{rm}}, it still fails sometimes. This should be fixed with more persistent cleanup code.


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org