Return-Path: X-Original-To: apmail-cordova-issues-archive@minotaur.apache.org Delivered-To: apmail-cordova-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id BBC7B179ED for ; Thu, 2 Apr 2015 13:30:01 +0000 (UTC) Received: (qmail 70600 invoked by uid 500); 2 Apr 2015 13:28:59 -0000 Delivered-To: apmail-cordova-issues-archive@cordova.apache.org Received: (qmail 70571 invoked by uid 500); 2 Apr 2015 13:28:59 -0000 Mailing-List: contact issues-help@cordova.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@cordova.apache.org Received: (qmail 70476 invoked by uid 99); 2 Apr 2015 13:28:59 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 02 Apr 2015 13:28:59 +0000 Date: Thu, 2 Apr 2015 13:28:58 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: issues@cordova.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (CB-8635) InAppBrowser on Windows adds 40px gray border, wrapper div without class or id MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/CB-8635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14392516#comment-14392516 ] ASF GitHub Bot commented on CB-8635: ------------------------------------ Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-inappbrowser/pull/98 > InAppBrowser on Windows adds 40px gray border, wrapper div without class or id > ------------------------------------------------------------------------------ > > Key: CB-8635 > URL: https://issues.apache.org/jira/browse/CB-8635 > Project: Apache Cordova > Issue Type: Bug > Components: Plugin InAppBrowser > Affects Versions: 3.6.0 > Environment: Windows 8.1, Windows Phone 8.1 > Reporter: Brandon Paddock > > The InAppBrowserProxy on Windows 8.1 does some weird things. One of them is that it adds a wrapper div with a bunch of inline styles on it, including a gray 40px border on all sides. This appears even if you set the "location=no" option to disable the default browser controls. > Because this div is inserted directly under the body element with no id or class, you can't override its styling via CSS (and since it uses inline styles, you'd have to use !important to override them). > Suggested fixes: > 1) Assign a class name to the div so it can be styled. > 2) Don't use an inline style for the default styling. Use CSS. > 3) Don't put this weird gray border in the default styling (it isn't there on Android so why put it there on Windows?) > 4) Or, remove the div entirely (at least in the location=no case). -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org For additional commands, e-mail: issues-help@cordova.apache.org