Return-Path: X-Original-To: apmail-cordova-issues-archive@minotaur.apache.org Delivered-To: apmail-cordova-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 961D017B51 for ; Wed, 1 Apr 2015 17:53:09 +0000 (UTC) Received: (qmail 13760 invoked by uid 500); 1 Apr 2015 17:52:53 -0000 Delivered-To: apmail-cordova-issues-archive@cordova.apache.org Received: (qmail 13743 invoked by uid 500); 1 Apr 2015 17:52:53 -0000 Mailing-List: contact issues-help@cordova.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@cordova.apache.org Received: (qmail 13725 invoked by uid 99); 1 Apr 2015 17:52:53 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 01 Apr 2015 17:52:53 +0000 Date: Wed, 1 Apr 2015 17:52:53 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: issues@cordova.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (CB-8484) Cordova package support for Android MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/CB-8484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14391074#comment-14391074 ] ASF GitHub Bot commented on CB-8484: ------------------------------------ Github user agrieve commented on a diff in the pull request: https://github.com/apache/cordova-android/pull/164#discussion_r27593203 --- Diff: bin/templates/cordova/lib/build.js --- @@ -422,11 +500,18 @@ function parseOpts(options, resolvedTarget) { module.exports.runClean = function(options) { var opts = parseOpts(options); var builder = builders[opts.buildMethod]; - return builder.prepEnv() + return builder.prepEnv(opts) .then(function() { - return builder.clean(opts.extraArgs); + return builder.clean(opts); }).then(function() { shell.rm('-rf', path.join(ROOT, 'out')); + + ['debug', 'release'].forEach(function(config) { + var propertiesFilePath = path.join(ROOT, config + SIGNING_PROPERTIES); + if(isAutoGenerated(propertiesFilePath)){ + shell.rm('-f', propertiesFilePath); --- End diff -- I don't feel strongly. Let's ship it! :) > Cordova package support for Android > ----------------------------------- > > Key: CB-8484 > URL: https://issues.apache.org/jira/browse/CB-8484 > Project: Apache Cordova > Issue Type: Sub-task > Components: Android > Affects Versions: 4.0.0 > Reporter: Nikhil Khandelwal > Assignee: Nikhil Khandelwal > > Details of the design here: > https://docs.google.com/document/d/1tJQ9OoGrrMhZcLI3mg46rGzAfbiQu9PuNBL1auAMGFM/edit# -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org For additional commands, e-mail: issues-help@cordova.apache.org