cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Steve Gill (JIRA)" <j...@apache.org>
Subject [jira] [Resolved] (CB-8934) cordova.config not being used during cordova.create
Date Thu, 30 Apr 2015 03:57:05 GMT

     [ https://issues.apache.org/jira/browse/CB-8934?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Steve Gill resolved CB-8934.
----------------------------
    Resolution: Fixed

Fixed the issue. Now config.json will get merged into cfg object. cfg takes preference though.


Downstreams might encounter this bug. Ran into this problem because the PhoneGap-CLI was using
config.json to set templates. 

> cordova.config not being used during cordova.create
> ---------------------------------------------------
>
>                 Key: CB-8934
>                 URL: https://issues.apache.org/jira/browse/CB-8934
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: CordovaLib
>    Affects Versions: 5.0.0
>            Reporter: Steve Gill
>            Assignee: Steve Gill
>             Fix For: 5.0.1
>
>
> With the recent changes of getting cordova app-hello-world from npm, cordova.config stopped
being used during cordova create. 
> The offending line is https://github.com/apache/cordova-lib/blob/master/cordova-lib/src/cordova/create.js#L58
> Issue is, by the time it reaches that line, cfg is always {} if no config was passed
in via the command line. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message