cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-8928) plugin-dialogs: prompt fails on Windows when 'toStaticHTML' is not defined
Date Tue, 28 Apr 2015 22:52:06 GMT

    [ https://issues.apache.org/jira/browse/CB-8928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14518290#comment-14518290
] 

ASF GitHub Bot commented on CB-8928:
------------------------------------

GitHub user robpaveza opened a pull request:

    https://github.com/apache/cordova-plugin-dialogs/pull/52

    CB-8928: prompt fails if toStaticHTML is missing

    Removed direct call to toStaticHTML, only call it if we are sure it's present.
    
    Had to fix the PR, sorry for the earlier misfire.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/MSOpenTech/cordova-plugin-dialogs CB-8928

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-dialogs/pull/52.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #52
    
----
commit 15e55c51607a09f70021b793d942a59eac78b1a0
Author: Rob Paveza <rob.paveza@microsoft.com>
Date:   2015-04-28T22:08:03Z

    CB-8928: Removed direct call to toStaticHTML, only call it if we are sure
    it's present.

----


> plugin-dialogs: prompt fails on Windows when 'toStaticHTML' is not defined
> --------------------------------------------------------------------------
>
>                 Key: CB-8928
>                 URL: https://issues.apache.org/jira/browse/CB-8928
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: Plugin Dialogs
>            Reporter: Rob Paveza
>            Priority: Minor
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message