cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <>
Subject [jira] [Commented] (CB-8803) Medic builds sometimes fail cleanup on Windows
Date Thu, 09 Apr 2015 22:29:12 GMT


ASF GitHub Bot commented on CB-8803:

Github user dblotsky commented on a diff in the pull request:
    --- Diff: buildbot-conf/cordova.conf ---
    @@ -229,6 +229,8 @@ plugins_cleanup_steps = [
         NPMInstall(command=['shelljs'], what='shelljs'),
         RMRF('~/.cordova/*', description='removing cache', haltOnFailure=False),
         RMRF(BASE_WORKDIR + '/*', description='cleaning workspace', haltOnFailure=False),
    +    RMRF(BASE_WORKDIR + '/*', description='cleaning workspace again', haltOnFailure=False),
    +    RMRF(BASE_WORKDIR + '/*', description='cleaning workspace yet again', haltOnFailure=True),
    --- End diff --
    The solid solution, and hence the "proper fix", is to offload this work to a custom cleanup
script. We currently have a chicken-and-egg problem because we need to download the script
before we clean up, and then clean it up using itself. In the near future we should consolidate
the medic scripts into an executable called `medic` that is not part of the downloaded repositories,
and we will be able to clean up by calling something like:
        medic clean
        medic update_config
        medic build windows
    This will move a lot of logic out of buildbot, and it will also make the automated build
tools more usable outside of buildbot.
    For now, the three steps are a very simple effective fix for the intermittent problem.

> Medic builds sometimes fail cleanup on Windows
> ----------------------------------------------
>                 Key: CB-8803
>                 URL:
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: Medic, Windows
>    Affects Versions: Master
>         Environment: Any cordova-medic setup on Windows.
>            Reporter: Dmitry Blotsky
>            Priority: Minor
>              Labels: medic, rm, windows
>   Original Estimate: 24h
>  Remaining Estimate: 24h
> On Windows, sometimes the cleanup step fails because of some stray process briefly looking
at a directory while the directory is being deleted.
> Although medic uses shelljs's implementation of {{rm}}, it still fails sometimes. This
should be fixed with more persistent cleanup code.

This message was sent by Atlassian JIRA

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message