cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-8803) Medic builds sometimes fail cleanup on Windows
Date Wed, 08 Apr 2015 18:51:12 GMT

    [ https://issues.apache.org/jira/browse/CB-8803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14485787#comment-14485787
] 

ASF GitHub Bot commented on CB-8803:
------------------------------------

Github user dblotsky commented on a diff in the pull request:

    https://github.com/apache/cordova-medic/pull/40#discussion_r28001029
  
    --- Diff: buildbot-conf/cordova.conf ---
    @@ -229,6 +229,8 @@ plugins_cleanup_steps = [
         NPMInstall(command=['shelljs'], what='shelljs'),
         RMRF('~/.cordova/*', description='removing cache', haltOnFailure=False),
         RMRF(BASE_WORKDIR + '/*', description='cleaning workspace', haltOnFailure=False),
    +    RMRF(BASE_WORKDIR + '/*', description='cleaning workspace again', haltOnFailure=False),
    +    RMRF(BASE_WORKDIR + '/*', description='cleaning workspace yet again', haltOnFailure=True),
    --- End diff --
    
    Both are functionally equivalent. I think the three repeated steps are a bit more clear,
since it's very easy to see that it's repeated, and they make it evident on the waterfall
page that this is something that still needs to be fixed properly.
    
    Also, we haven't seen this issue for `~/.cordova/*`.


> Medic builds sometimes fail cleanup on Windows
> ----------------------------------------------
>
>                 Key: CB-8803
>                 URL: https://issues.apache.org/jira/browse/CB-8803
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: Medic, Windows
>    Affects Versions: Master
>         Environment: Any cordova-medic setup on Windows.
>            Reporter: Dmitry Blotsky
>            Priority: Minor
>              Labels: medic, rm, windows
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> On Windows, sometimes the cleanup step fails because of some stray process briefly looking
at a directory while the directory is being deleted.
> Although medic uses shelljs's implementation of {{rm}}, it still fails sometimes. This
should be fixed with more persistent cleanup code.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message