cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-8799) Ensure platforms and plugins save src/version to single attribute in config.xml
Date Mon, 06 Apr 2015 14:25:13 GMT

    [ https://issues.apache.org/jira/browse/CB-8799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14481254#comment-14481254
] 

ASF GitHub Bot commented on CB-8799:
------------------------------------

GitHub user TimBarham opened a pull request:

    https://github.com/apache/cordova-lib/pull/202

    CB-8799 Save plugin/platform src and version to 'spec' attribute.

    When `--save` option is used, plugin and platform source location or version value is
saved to `spec` attribute in `config.xml` (source location takes priority over version). This
replaces `version` attribute for platforms, and `src` and `version` attributes for plugins.
    
    Also:
    
    * Updated semver dependency to 2.1.0 to support tilde range.
    * Ensure when save platform version (to platforms.json and config.xml) we save the version
that was actually installed.
    * Ensure when save platform version to config.xml we save it as a tilde range.
    
    Note that if it is decided we prefer to use `src` or `version` attributes instead of `spec`,
a branch with the equivalent change but using the `src` attribute can be found [here](https://github.com/apache/cordova-lib/compare/master...MSOpenTech:CB-8799-src),
and for the `version` attribute [here](https://github.com/apache/cordova-lib/compare/master...MSOpenTech:CB-8799-version).

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/MSOpenTech/cordova-lib CB-8799-spec

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-lib/pull/202.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #202
    
----
commit 2cae6de925ef1bde5d7ed580f3dd14043b4659a5
Author: Tim Barham <tim.barham@microsoft.com>
Date:   2015-04-06T13:42:29Z

    CB-8799 Save plugin/platform src and version to 'spec' attribute.
    
    When --save option is used, plugin and platform source location or version value is saved
to 'spec' attribute in config.xml (source location takes priority over version). This replaces
'version' attribute for platforms, and 'src' and 'version' attributes for plugins.
    
    Also:
    
    * Updated semver dependency to 2.1.0 to support tilde range.
    * Ensure when save platform version (to platforms.json and config.xml) we save the version
that was actually installed.
    * Ensure when save platform version to config.xml we save it as a tilde range.

----


> Ensure platforms and plugins save src/version to single attribute in config.xml
> -------------------------------------------------------------------------------
>
>                 Key: CB-8799
>                 URL: https://issues.apache.org/jira/browse/CB-8799
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: CordovaLib
>            Reporter: Tim Barham
>
> Currently when saving to config.xml, platforms save source or version into version attribute,
and plugins save them separately into src and version attributes. They should both save to
a single attribute (source taking priority over version) - that attribute might be called
'src', 'version' or 'spec'.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message