cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-8484) Cordova package support for Android
Date Wed, 01 Apr 2015 17:19:53 GMT

    [ https://issues.apache.org/jira/browse/CB-8484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14391015#comment-14391015
] 

ASF GitHub Bot commented on CB-8484:
------------------------------------

Github user nikhilkh commented on a diff in the pull request:

    https://github.com/apache/cordova-android/pull/164#discussion_r27589905
  
    --- Diff: bin/templates/cordova/lib/build.js ---
    @@ -360,9 +391,15 @@ function parseOpts(options, resolvedTarget) {
         var multiValueArgs = {
           'versionCode': true,
           'minSdkVersion': true,
    -      'gradleArg': true
    +      'gradleArg': true,
    +      'keystore' : true,
    +      'alias' : true,
    +      'password' : true,
    +      'keytorePassword' : true,
    --- End diff --
    
    Good catch! Fixed in next iteration!


> Cordova package support for Android
> -----------------------------------
>
>                 Key: CB-8484
>                 URL: https://issues.apache.org/jira/browse/CB-8484
>             Project: Apache Cordova
>          Issue Type: Sub-task
>          Components: Android
>    Affects Versions: 4.0.0
>            Reporter: Nikhil Khandelwal
>            Assignee: Nikhil Khandelwal
>
> Details of the design here:
> https://docs.google.com/document/d/1tJQ9OoGrrMhZcLI3mg46rGzAfbiQu9PuNBL1auAMGFM/edit#



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message