cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-8484) Cordova package support for Android
Date Wed, 01 Apr 2015 00:34:54 GMT

    [ https://issues.apache.org/jira/browse/CB-8484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14389770#comment-14389770
] 

ASF GitHub Bot commented on CB-8484:
------------------------------------

Github user agrieve commented on a diff in the pull request:

    https://github.com/apache/cordova-android/pull/164#discussion_r27536475
  
    --- Diff: bin/templates/cordova/lib/build.js ---
    @@ -422,11 +500,18 @@ function parseOpts(options, resolvedTarget) {
     module.exports.runClean = function(options) {
         var opts = parseOpts(options);
         var builder = builders[opts.buildMethod];
    -    return builder.prepEnv()
    +    return builder.prepEnv(opts)
         .then(function() {
    -        return builder.clean(opts.extraArgs);
    +        return builder.clean(opts);
         }).then(function() {
             shell.rm('-rf', path.join(ROOT, 'out'));
    +
    +        ['debug', 'release'].forEach(function(config) {
    +            var propertiesFilePath = path.join(ROOT, config + SIGNING_PROPERTIES);
    +            if(isAutoGenerated(propertiesFilePath)){
    +                shell.rm('-f', propertiesFilePath);
    --- End diff --
    
    prepEnv (which is called in this case) takes care of deleting these if there is no supplied
signing args. I don't think there's a need to delete them unconditionally since we don't bother
deleting other build-time-supplied-files (like build.xml, build.gradle)


> Cordova package support for Android
> -----------------------------------
>
>                 Key: CB-8484
>                 URL: https://issues.apache.org/jira/browse/CB-8484
>             Project: Apache Cordova
>          Issue Type: Sub-task
>          Components: Android
>    Affects Versions: 4.0.0
>            Reporter: Nikhil Khandelwal
>            Assignee: Nikhil Khandelwal
>
> Details of the design here:
> https://docs.google.com/document/d/1tJQ9OoGrrMhZcLI3mg46rGzAfbiQu9PuNBL1auAMGFM/edit#



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message