cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-3360) Set custom InAppBrowser user-agent
Date Thu, 02 Apr 2015 20:42:54 GMT

    [ https://issues.apache.org/jira/browse/CB-3360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14393341#comment-14393341
] 

ASF GitHub Bot commented on CB-3360:
------------------------------------

Github user sinofool commented on a diff in the pull request:

    https://github.com/apache/cordova-android/pull/162#discussion_r27695146
  
    --- Diff: framework/src/org/apache/cordova/engine/SystemWebViewEngine.java ---
    @@ -199,7 +199,19 @@ private void initWebViewSettings() {
             
             // Fix for CB-1405
             // Google issue 4641
    -        settings.getUserAgentString();
    +        String defaultUserAgent = settings.getUserAgentString();
    +
    +        // Fix for CB-3360
    +        String overrideUserAgent = getCordovaWebView().getPreferences().getString("OverrideUserAgent",
null);
    --- End diff --
    
    @agrieve Yes, thanks for the great suggestion, I will change it this weekend.


> Set custom InAppBrowser user-agent
> ----------------------------------
>
>                 Key: CB-3360
>                 URL: https://issues.apache.org/jira/browse/CB-3360
>             Project: Apache Cordova
>          Issue Type: Improvement
>          Components: Android, BlackBerry, Plugin InAppBrowser, WP8
>    Affects Versions: 2.7.0
>         Environment: iOS, Android, WP8, BlackBerry
>            Reporter: Kevin Simpson
>            Assignee: Joe Bowser
>            Priority: Minor
>              Labels: Cordova, InAppBrowser, android
>
> Currently you can set a custom user-agent for the main Cordova webview by overriding
the init method for the DroidGap class. However, when opening a page in the InAppBrowser,
that webview will still contain the default user-agent.
> There are two solutions that I have thought of to this:
> 1. Set the user-agent of the InAppBrowser webview to whatever the user-agent in the Cordova
webview is set to. (This is what I am currently doing, as it was a one line change, but it
requires rebuilding Cordova manually)
> 2. Have some sort of configuration option to set the user-agent for the InAppBrowser.
This would allow a different user-agent from the main webview, but is also a more involved
change.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message