Mailing-List: contact issues-help@cordova.apache.org; run by ezmlm
Precedence: bulk
Date: Tue, 3 Mar 2015 20:07:04 +0000 (UTC)
From: "ASF subversion and git services (JIRA)" <jira@apache.org>
To: issues@cordova.apache.org
Message-ID: <JIRA.12779151.1425409794000.67208.1425413224851@Atlassian.JIRA>
In-Reply-To: <JIRA.12779151.1425409794000@Atlassian.JIRA>
References: <JIRA.12779151.1425409794000@Atlassian.JIRA>
 <JIRA.12779151.1425409794484@arcas>
Subject: [jira] [Commented] (CB-8597) Change cordova-lib create.js to import
 config.xml of app hello world by using the --copy-from code path
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/CB-8597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14345645#comment-14345645 ] 

ASF subversion and git services commented on CB-8597:
-----------------------------------------------------

Commit d4eb5930b555545838229f0a8944716018ba3c1b in cordova-app-hello-world's branch refs/heads/copy-from-app-hello-world from [~mmocny]
[ https://git-wip-us.apache.org/repos/asf?p=cordova-app-hello-world.git;h=d4eb593 ]

[CB-8597] First attempt at importing cordova-app-hello-world via npm dependency


> Change cordova-lib create.js to import config.xml of app hello world by using the --copy-from code path
> -------------------------------------------------------------------------------------------------------
>
>                 Key: CB-8597
>                 URL: https://issues.apache.org/jira/browse/CB-8597
>             Project: Apache Cordova
>          Issue Type: Improvement
>          Components: App Hello World, CLI, CordovaLib
>            Reporter: Michal Mocny
>            Assignee: Michal Mocny
>
> Right now, when creating a new project with CLI, we will lazy_load the hello world application to load its www/.  We will not, however, load its config.xml -- we always use the cordova-lib default.
> This is needlessly complex (aka, special code paths, requires lazy_loading when everything else has moved to npm), given that create already supports `--copy-from` which imports both www/ and config.xml (and hooks and merges).
> I think we should:
> - Add a config.xml to app hello world.
> - Remove many of the special cases in cordova-lib create(), and always just expect a path to import, aka always use the --copy-from/--link-to logic.
> - Change cordova-cli to call create() with a path to app hello world if --copy-from/--link-to are not in cli args.
> - Publish app hello world to npm and add it to cordova-cli dependencies.
> Note: some users use --copy-from directly to a www/, which has no config.xml.  We should still support that use case, either by leaving the cordova-lib config.xml template, or better yet, by using the app hello world config.xml for this use case.


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org