Return-Path: X-Original-To: apmail-cordova-issues-archive@minotaur.apache.org Delivered-To: apmail-cordova-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 6401A17CEA for ; Wed, 11 Mar 2015 17:21:46 +0000 (UTC) Received: (qmail 93889 invoked by uid 500); 11 Mar 2015 17:21:40 -0000 Delivered-To: apmail-cordova-issues-archive@cordova.apache.org Received: (qmail 93862 invoked by uid 500); 11 Mar 2015 17:21:40 -0000 Mailing-List: contact issues-help@cordova.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@cordova.apache.org Received: (qmail 93773 invoked by uid 99); 11 Mar 2015 17:21:40 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 11 Mar 2015 17:21:40 +0000 Date: Wed, 11 Mar 2015 17:21:40 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: issues@cordova.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (CB-8595) Merge platform specific code into one place MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/CB-8595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14357235#comment-14357235 ] ASF GitHub Bot commented on CB-8595: ------------------------------------ Github user purplecabbage commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/183#discussion_r26233744 --- Diff: cordova-lib/src/PluginInfo.js --- @@ -288,6 +293,19 @@ function PluginInfo(dirname) { return ret; }); }; + + self.getFilesAndFrameworks = getFilesAndFrameworks; + function getFilesAndFrameworks(platform) { + var items = []; + // Please avoid changing the order of the calls below, files will be + // installed in this order. + items = items.concat(self.getSourceFiles(platform)); + items = items.concat(self.getHeaderFiles(platform)); + items = items.concat(self.getResourceFiles(platform)); + items = items.concat(self.getFrameworks(platform)); + items = items.concat(self.getLibFiles(platform)); --- End diff -- I would recommend : var items = []; items = items.concat(self.getSourceFiles(platform), self.getHeaderFiles(platform), ... ); // unnecessarily tricky code is a barrier to some, clarity is king > Merge platform specific code into one place > ------------------------------------------- > > Key: CB-8595 > URL: https://issues.apache.org/jira/browse/CB-8595 > Project: Apache Cordova > Issue Type: Improvement > Reporter: Mark Koudritsky > Assignee: Mark Koudritsky > > Currently we have two separate places for platform specific code > src/cordova/metadata > src/plugman/platforms > This is confusing. > Once consolidated the platform specific code will be much easier to move to the platform repos where it belongs. -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org For additional commands, e-mail: issues-help@cordova.apache.org