Return-Path: X-Original-To: apmail-cordova-issues-archive@minotaur.apache.org Delivered-To: apmail-cordova-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 816E6105D1 for ; Tue, 3 Mar 2015 08:02:05 +0000 (UTC) Received: (qmail 81154 invoked by uid 500); 3 Mar 2015 08:02:05 -0000 Delivered-To: apmail-cordova-issues-archive@cordova.apache.org Received: (qmail 81133 invoked by uid 500); 3 Mar 2015 08:02:05 -0000 Mailing-List: contact issues-help@cordova.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@cordova.apache.org Received: (qmail 81116 invoked by uid 99); 3 Mar 2015 08:02:05 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 03 Mar 2015 08:02:05 +0000 Date: Tue, 3 Mar 2015 08:02:05 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: issues@cordova.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (CB-8580) PluginResult.Status.NO_RESULT is broken (error CB is invoked instead) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/CB-8580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14344704#comment-14344704 ] ASF GitHub Bot commented on CB-8580: ------------------------------------ Github user EddyVerbruggen closed the pull request at: https://github.com/apache/cordova-wp8/pull/77 > PluginResult.Status.NO_RESULT is broken (error CB is invoked instead) > --------------------------------------------------------------------- > > Key: CB-8580 > URL: https://issues.apache.org/jira/browse/CB-8580 > Project: Apache Cordova > Issue Type: Bug > Components: WP8 > Affects Versions: 3.7.0 > Reporter: Eddy Verbruggen > Assignee: Jesse MacFadyen > > Before 3.7.0 a plugin could respond with: > PluginResult pluginResult = new PluginResult(PluginResult.Status.NO_RESULT); > pluginResult.KeepCallback = true; > this.DispatchCommandResult(pluginResult); > This meant the successCB nor the errorCB was invoked awaiting a further response from native code. > Since 3.7.0 however in this case the errorCB is invoked due to this difference: > Before 3.7.0: https://github.com/apache/cordova-wp8/blob/3.5.x/common/www/cordova.js#L293 > Since 3.7.0: https://github.com/apache/cordova-wp8/blob/3.7.1/template/www/cordova.js#L287 > I'd love to see the old behavior in a future release. -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org For additional commands, e-mail: issues-help@cordova.apache.org