Return-Path: 
 <issues-return-39197-apmail-cordova-issues-archive=cordova.apache.org@cordova.apache.org>
X-Original-To: apmail-cordova-issues-archive@minotaur.apache.org
Delivered-To: apmail-cordova-issues-archive@minotaur.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id 3A99C10915
	for <apmail-cordova-issues-archive@minotaur.apache.org>;
 Tue,  3 Mar 2015 19:59:12 +0000 (UTC)
Received: (qmail 40041 invoked by uid 500); 3 Mar 2015 19:59:05 -0000
Delivered-To: apmail-cordova-issues-archive@cordova.apache.org
Received: (qmail 40028 invoked by uid 500); 3 Mar 2015 19:59:05 -0000
Mailing-List: contact issues-help@cordova.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:issues-help@cordova.apache.org>
List-Unsubscribe: <mailto:issues-unsubscribe@cordova.apache.org>
List-Post: <mailto:issues@cordova.apache.org>
List-Id: <issues.cordova.apache.org>
Delivered-To: mailing list issues@cordova.apache.org
Received: (qmail 39923 invoked by uid 99); 3 Mar 2015 19:59:05 -0000
Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28)
    by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 03 Mar 2015 19:59:05 +0000
Date: Tue, 3 Mar 2015 19:59:05 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: issues@cordova.apache.org
Message-ID: <JIRA.12777803.1424933610000.67155.1425412745238@Atlassian.JIRA>
In-Reply-To: <JIRA.12777803.1424933610000@Atlassian.JIRA>
References: <JIRA.12777803.1424933610000@Atlassian.JIRA>
 <JIRA.12777803.1424933610016@arcas>
Subject: [jira] [Commented] (CB-8551) Setup fetching from npm as fallback
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394


    [ https://issues.apache.org/jira/browse/CB-8551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14345632#comment-14345632 ] 

ASF GitHub Bot commented on CB-8551:
------------------------------------

Github user stevengill commented on a diff in the pull request:

    https://github.com/apache/cordova-lib/pull/175#discussion_r25720721
  
    --- Diff: cordova-lib/src/plugman/registry/registry.js ---
    @@ -218,10 +205,18 @@ module.exports = {
     
     /**
      * @method initSettings
    + * @param {Boolean} using npm registry
      * @return {Promise.<Object>} Promised settings.
      */
    -function initSettings() {
    +function initSettings(npm) {
         var settings = module.exports.settings;
    +    var registryURL = 'http://registry.cordova.io';
    +
    +    //if npm is true, use npm registry
    +    if(npm) {
    +        registryURL = 'http://registry.npmjs.org';
    +    }
    +
    --- End diff --
    
    TBH, I prefer `if(npm) {...}` to `?`. I think it is just easier to read and leaves us open to add other changes if we realize we need to. If I am unaware of some performance boost or something, please let me know. 


> Setup fetching from npm as fallback
> -----------------------------------
>
>                 Key: CB-8551
>                 URL: https://issues.apache.org/jira/browse/CB-8551
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: CordovaLib
>            Reporter: Steve Gill
>            Assignee: Steve Gill
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org