Mailing-List: contact issues-help@cordova.apache.org; run by ezmlm
Precedence: bulk
Date: Thu, 26 Mar 2015 16:06:53 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: issues@cordova.apache.org
Message-ID: <JIRA.12762575.1418911811000.37790.1427386013607@Atlassian.JIRA>
In-Reply-To: <JIRA.12762575.1418911811000@Atlassian.JIRA>
References: <JIRA.12762575.1418911811000@Atlassian.JIRA>
 <JIRA.12762575.1418911811418@arcas>
Subject: [jira] [Commented] (CB-8185) Add online and offiline
 plugin-network-information events support for the Browser platform
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/CB-8185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14382116#comment-14382116 ] 

ASF GitHub Bot commented on CB-8185:
------------------------------------

Github user vladimir-kotikov commented on the pull request:

    https://github.com/apache/cordova-plugin-network-information/pull/25#issuecomment-86594471
  
    My bad :dizzy_face: Fixed in https://github.com/apache/cordova-plugin-network-information/commit/481bdd93b023f808c301943ac6c541e3633aeee4


> Add online and offiline plugin-network-information events support for the Browser platform
> ------------------------------------------------------------------------------------------
>
>                 Key: CB-8185
>                 URL: https://issues.apache.org/jira/browse/CB-8185
>             Project: Apache Cordova
>          Issue Type: Improvement
>          Components: Browser, Plugin Network Information
>            Reporter: Sergey Shakhnazarov
>            Assignee: Vladimir Kotikov
>
> Initial implementation used XHR to check whether we connected to network or not. Two main problems of this approach is that it used CORS and wasn't able to detect local network access.
> So for better compatibility with specs it is better to use browsers native implementation of {{navigator.onLine}} property which properly handles all the aspects of network accessibility.
> {{navigator.onLine}} available for all modern browsers: http://caniuse.com/#feat=online-status


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org