Return-Path: X-Original-To: apmail-cordova-issues-archive@minotaur.apache.org Delivered-To: apmail-cordova-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id D6195101F1 for ; Tue, 17 Mar 2015 08:46:38 +0000 (UTC) Received: (qmail 32916 invoked by uid 500); 17 Mar 2015 08:46:38 -0000 Delivered-To: apmail-cordova-issues-archive@cordova.apache.org Received: (qmail 32893 invoked by uid 500); 17 Mar 2015 08:46:38 -0000 Mailing-List: contact issues-help@cordova.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@cordova.apache.org Received: (qmail 32874 invoked by uid 99); 17 Mar 2015 08:46:38 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 17 Mar 2015 08:46:38 +0000 Date: Tue, 17 Mar 2015 08:46:38 +0000 (UTC) From: "Shazron Abdullah (JIRA)" To: issues@cordova.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (CB-7767) [iOS] Remove usage of NSData+Base64 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/CB-7767?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shazron Abdullah updated CB-7767: --------------------------------- Description: There is built in support since iOS 7. Once we drop iOS 6, we can do this. https://developer.apple.com/library/ios/documentation/Cocoa/Reference/Foundation/Classes/NSData_Class/index.html#//apple_ref/doc/uid/20000172-SW36 Lines: 1. https://github.com/apache/cordova-ios/blob/1a44a4eed9f22024cc0480733a4c21af63f92ab5/CordovaLib/Classes/CDVInvokedUrlCommand.m#L88 2. https://github.com/apache/cordova-ios/blob/1a44a4eed9f22024cc0480733a4c21af63f92ab5/CordovaLib/Classes/CDVPluginResult.m#L40 Replace with: 1. [[NSData alloc] initWithBase64EncodedString:data options:0] 2. [data base64EncodedStringWithOptions:0] Test mobilespec bridge benchmark before this change and after, then report the results. was: There is built in support since iOS 7. Once we drop iOS 6, we can do this. https://developer.apple.com/library/ios/documentation/Cocoa/Reference/Foundation/Classes/NSData_Class/index.html#//apple_ref/doc/uid/20000172-SW36 Lines: 1. https://github.com/apache/cordova-ios/blob/1a44a4eed9f22024cc0480733a4c21af63f92ab5/CordovaLib/Classes/CDVInvokedUrlCommand.m#L88 2. https://github.com/apache/cordova-ios/blob/1a44a4eed9f22024cc0480733a4c21af63f92ab5/CordovaLib/Classes/CDVPluginResult.m#L40 Replace with: 1. [[NSData alloc] initWithBase64EncodedString:data options:0] 2. [data base64EncodedStringWithOptions:0] > [iOS] Remove usage of NSData+Base64 > ------------------------------------ > > Key: CB-7767 > URL: https://issues.apache.org/jira/browse/CB-7767 > Project: Apache Cordova > Issue Type: Bug > Components: iOS > Reporter: Shazron Abdullah > Fix For: 4.0.0 > > > There is built in support since iOS 7. Once we drop iOS 6, we can do this. > https://developer.apple.com/library/ios/documentation/Cocoa/Reference/Foundation/Classes/NSData_Class/index.html#//apple_ref/doc/uid/20000172-SW36 > Lines: > 1. https://github.com/apache/cordova-ios/blob/1a44a4eed9f22024cc0480733a4c21af63f92ab5/CordovaLib/Classes/CDVInvokedUrlCommand.m#L88 > 2. https://github.com/apache/cordova-ios/blob/1a44a4eed9f22024cc0480733a4c21af63f92ab5/CordovaLib/Classes/CDVPluginResult.m#L40 > Replace with: > 1. [[NSData alloc] initWithBase64EncodedString:data options:0] > 2. [data base64EncodedStringWithOptions:0] > Test mobilespec bridge benchmark before this change and after, then report the results. -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org For additional commands, e-mail: issues-help@cordova.apache.org