cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-8754) Auto-restoring a plugin fails when adding a platform
Date Fri, 27 Mar 2015 14:23:53 GMT

    [ https://issues.apache.org/jira/browse/CB-8754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14383900#comment-14383900
] 

ASF GitHub Bot commented on CB-8754:
------------------------------------

Github user agrieve commented on a diff in the pull request:

    https://github.com/apache/cordova-lib/pull/194#discussion_r27298165
  
    --- Diff: cordova-lib/src/plugman/registry/registry.js ---
    @@ -223,11 +211,13 @@ module.exports = {
      * @param {Boolean} determines if we are using the npm registry
      * @return {Promise.<Object>} Promised settings.
      */
    -function initSettings() {
    +function initSettings(returnEmptySettings) {
         var settings = module.exports.settings;
     
         // check if settings already set
    -    if(settings !== null) return Q(settings);
    +    if(settings !== null) {
    --- End diff --
    
    This returns settings even when returnEmptySettings is true. should it?


> Auto-restoring a plugin fails when adding a platform
> ----------------------------------------------------
>
>                 Key: CB-8754
>                 URL: https://issues.apache.org/jira/browse/CB-8754
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: CordovaLib
>    Affects Versions: Master
>            Reporter: Tim Barham
>            Assignee: Tim Barham
>   Original Estimate: 5h
>  Remaining Estimate: 5h
>
> Start with a blank Cordova app, then enter the following:
> {noformat}
> cordova plugin add org.apache.cordova.camera --save
> cordova plugin remove org.apache.cordova.camera
> cordova platform add browser
> {noformat}
>   
> The final step should restore the camera plugin, but it fails with the following exception:
> {noformat}
> TypeError: Cannot read property 'latest' of undefined
>     at next (D:\GIT\Cordova\cordova-lib\cordova-lib\node_modules\npm\lib\cache.js:694:35)
>     at D:\GIT\Cordova\cordova-lib\cordova-lib\node_modules\npm\lib\cache.js:682:5
>     at RegClient.get_ (D:\GIT\Cordova\cordova-lib\cordova-lib\node_modules\npm\node_modules\npm-registry-client\lib\get.js:105:14)
>     at RegClient.<anonymous> (D:\GIT\Cordova\cordova-lib\cordova-lib\node_modules\npm\node_modules\npm-registry-client\lib\get.js:41:12)
>     at fs.js:336:14
>     at D:\GIT\Cordova\cordova-lib\cordova-lib\node_modules\npm\node_modules\graceful-fs\graceful-fs.js:103:5
>     at FSReqWrap.oncomplete (fs.js:99:15)
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message