cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <>
Subject [jira] [Commented] (CB-8753) Maintain splash screen aspect ratio
Date Mon, 30 Mar 2015 18:14:56 GMT


ASF GitHub Bot commented on CB-8753:

Github user AlexTalis commented on a diff in the pull request:
    --- Diff: src/android/ ---
    @@ -37,6 +39,19 @@ Licensed to the Apache Software Foundation (ASF) under one
     import org.json.JSONArray;
     import org.json.JSONException;
    + * Splash Screen plugin. Uses the following preferences:
    + * <ul>
    + * <li>SplashScreen: Splash screen resource name.</li>
    + * <li>SplashScreenDelay: How long splash screen should be shown in milliseconds.</li>
    + * <li>SplashMaintainAspectRatio: Maintain aspect ratio of the drawable, like CSS
    --- End diff --
    Will do after we finalize the changes.

> Maintain splash screen aspect ratio
> -----------------------------------
>                 Key: CB-8753
>                 URL:
>             Project: Apache Cordova
>          Issue Type: Improvement
>          Components: Android
>    Affects Versions: 3.7.1
>         Environment: Android
>            Reporter: Alex Talis
>             Fix For: 3.8.0, 4.0.0, 3.7.1
>         Attachments: cur-land.png, cur-port.png, new-land.png, new-port.png
> I will be submitting a pull request for this enhancement shortly.
> Current splash screen scales images non-uniformly to fit into splash dialog. This approach
does not work well for many typical splash screen images that contain scenery or text and
look bad when aspect ratio is not preserved. 9-patch images may work, but they have to be
carefully designed so that the inside can be stretched without distorting important information.
> The purpose of this enhancement is to allow use of non-9-patch images without stretching,
similar to CSS "background-size:cover" capability. For this to work, splash images have to
have large safe area all around that can be safely cropped off.
> With this type of splash screen, it is usually necessary to use different images for
portrait and landscape orientations, so a second part of this enhancement is to add an option
to reload the drawable when orientation changes.
> Examples of the two preferences are shown below. Both are optional and default to False
to maintain current splash screen behavior.
> <preference name="SplashMaintainAspectRatio" value="true"/>
> <preference name="SplashReloadOnOrientationChange" value="true"/>

This message was sent by Atlassian JIRA

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message