cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-8741) Plugin save/restore should behave like npm
Date Fri, 27 Mar 2015 14:10:53 GMT

    [ https://issues.apache.org/jira/browse/CB-8741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14383874#comment-14383874
] 

ASF GitHub Bot commented on CB-8741:
------------------------------------

GitHub user TimBarham opened a pull request:

    https://github.com/apache/cordova-lib/pull/198

    CB-8741 Make plugin --save work more like npm install.

    1. `plugin add --save` now always saves version (in the form `^x.y.z`)
    2. `plugin add --save` now always overwrites an existing entry.
    3. `plugin add` now honors an existing version specified in `config.xml` when a plugin
is added without a specific version, even if the `--save` flag is specified.
    
    I also fixed a bug in `isUrl()` (in `util.js`) - `url.protocol` includes the colon, so
the protocol for a windows path is something like `c:` - 2 characters, not one.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/MSOpenTech/cordova-lib CB-8741

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-lib/pull/198.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #198
    
----
commit 8c9f3eec78ee5574d5392371b6b3cf4e5d1f19b2
Author: Tim Barham <tim.barham@microsoft.com>
Date:   2015-03-27T13:22:20Z

    CB-8741 Make plugin --save work more like npm install.
    
    1. 'plugin add --save' now always saves version (in the form '^x.y.z')
    2. 'plugin add --save' now always overwrites an existing entry.
    3. 'plugin add' now honors an existing version specified in config.xml when a plugin is
added without a specific version, even if the '--save' flag is specified.
    
    I also fixed a bug in isUrl() in util.js - url.protocol includes the colon, so the protocol
for a windows path is something like "c:" - 2 characters, not one.

----


> Plugin save/restore should behave like npm
> ------------------------------------------
>
>                 Key: CB-8741
>                 URL: https://issues.apache.org/jira/browse/CB-8741
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: CordovaLib
>    Affects Versions: Master
>            Reporter: Tim Barham
>            Assignee: Tim Barham
>   Original Estimate: 4h
>  Remaining Estimate: 4h
>
> Specifically:
> * Should *always* write out version (with '^') when saving.
> * Should write out version of plugin that ends up being installed, not version taken
from {{add}} command.
> * Should always overwrite existing entry when saving.
> * When no version specified in add command, should honor existing saved version even
when {{--save}} specified.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message