cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-8721) (Windows Phone 8, File-transfer download method) When specifying header with comma in it, fail callback is called
Date Thu, 26 Mar 2015 06:21:52 GMT

    [ https://issues.apache.org/jira/browse/CB-8721?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14381445#comment-14381445
] 

ASF GitHub Bot commented on CB-8721:
------------------------------------

GitHub user vladimir-kotikov opened a pull request:

    https://github.com/apache/cordova-plugin-file-transfer/pull/72

    CB-8721 Fixes incorrect headers and upload params parsing on wp8

    This is a bugfix for [CB-8721](https://issues.apache.org/jira/browse/CB-8721) which replaces
custom parding of headers being passed to native code as JSON objects with usage of DataContractSerializer.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/MSOpenTech/cordova-plugin-file-transfer CB-8721

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-file-transfer/pull/72.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #72
    
----
commit 21fb03aa9c55fbd1ca4df6097b466840e91c16b8
Author: Vladimir Kotikov <v-vlkoti@microsoft.com>
Date:   2015-03-24T08:19:19Z

    CB-8721 Fixes incorrect headers and upload params parsing on wp8

----


> (Windows Phone 8, File-transfer download method) When specifying header with comma in
it, fail callback is called
> -----------------------------------------------------------------------------------------------------------------
>
>                 Key: CB-8721
>                 URL: https://issues.apache.org/jira/browse/CB-8721
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: Plugin File Transfer
>            Reporter: Alexander Sorokin
>
> This code fails because header with comma in it is not parsed properly:
> {code}
> transfer.download(fileURL, localFilePath, function win(){}, function fail(){}, true,
>     {
>     headers: {
>         'If-Modified-Since': 'Sun, 06 Nov 1994 08:49:37 GMT'
>         }
>     });
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message