cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-8703) Add support for semver and device-specific targeting of config-file to Windows
Date Wed, 18 Mar 2015 18:10:39 GMT

    [ https://issues.apache.org/jira/browse/CB-8703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14367587#comment-14367587
] 

ASF GitHub Bot commented on CB-8703:
------------------------------------

GitHub user robpaveza opened a pull request:

    https://github.com/apache/cordova-lib/pull/187

    CB-8703: Add support for semver and device-specific targeting of config-file to Windows

    Allows config-file to target a virtual "package.appxmanifest" (already supported) and
specify versions of Windows via new versions and device-target attributes:
    
     <config-file target="package.appxmanifest" versions=">=8.1.0" ... />
     <config.file target="package.appxmanifest" device-target="phone" />
    
    This change also modifies the related <lib-file> and <framework> elements
for Windows to rename the "target" attribute to "device-target" in order to align the meaning
across elements. ("target" is preserved as an alias in order to be backwards-compatible).
    
    There is a matching PR for cordova-docs.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/robpaveza/cordova-lib CB-8703

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-lib/pull/187.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #187
    
----
commit f4dab3495422ea7e56678d9f478d86e1c35c1c66
Author: Rob Paveza <rob.paveza@microsoft.com>
Date:   2015-03-18T17:32:27Z

    CB-8703: Add support for semver and device-specific targeting of
    config-file to Windows.
    
    This change enables the use of "versions" and "device-target" attributes
    on the config-file element when the config-file element targets
    package.appxmanifest.  This allows for plugins to be more robust in the
    face of future versions of Windows which may require introduction of
    additional app manifests.

commit 215b3fcb2e9a95f8437b9f6de5074326fbfd724e
Author: Rob Paveza <rob.paveza@microsoft.com>
Date:   2015-03-18T17:45:10Z

    CB-8703: Merged into head.
    
    Conflicts:
    	cordova-lib/src/plugman/platforms/windows.js

commit fda0f6c42222cd0ddb8301b65c8d997f59049e7d
Author: Rob Paveza <rob.paveza@microsoft.com>
Date:   2015-03-18T18:06:24Z

    CB-8703: Test failure after merge to head.

----


> Add support for semver and device-specific targeting of config-file to Windows
> ------------------------------------------------------------------------------
>
>                 Key: CB-8703
>                 URL: https://issues.apache.org/jira/browse/CB-8703
>             Project: Apache Cordova
>          Issue Type: Improvement
>          Components: Windows
>            Reporter: Rob Paveza
>
> Allow <config-file> to target a virtual "package.appxmanifest" and specify versions
of Windows via new versions and device-target attributes:
>   <config target="package.appxmanifest" versions=">=8.1.0" ... />
>   <config target="package.appxmanifest" device-target="phone" />
> This change should also modify the related <lib-file> and <framework> elements
for Windows to rename the "target" attribute to "device-target" in order to align the meaning
across elements.  ("target" should remain as an alias in order to be backwards-compatible).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message