cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Shazron Abdullah (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-8659) iOS Plugins: Cordova-iOS 4.0.0 compatibility
Date Sat, 14 Mar 2015 17:21:38 GMT

    [ https://issues.apache.org/jira/browse/CB-8659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14361911#comment-14361911
] 

Shazron Abdullah commented on CB-8659:
--------------------------------------

Yes, UIWebView -- for now anyway. I think creation of the IAB's webview should be delegated
to the WebViewEngine. There's a lot of work to abstract this out:

1. We'll have to create our own delegate (CDVWebEngineNavigationDelegate) that abstracts UIWebViewDelegate
and WKNavigationDelegate. IAB will use that and set it on the CDVWebViewEngine. The CDVWebViewEngine
will map this to the appropriate internal delegate.
2. CDVInAppBrowserOptions will no longer make sense for WKWebView, since the options currently
map to UIWebView only. We'll have to map the options to their equivalents (if any) on the
WKWebViewEngine. Fortunately there is already a way to update settings on the CDVWKWebViewEngine
protocol
3. The CDVWKWebViewEngine should provide a way to create a WebView (UIView) in its interface.
This way we don't need to know the implementation details or delegates.

Anyways -- this is a lot of work, but it's not critical for 4.0.x release. I'll create a new
issue for this, and pull in the above PR on Monday if there are no more comments regarding
it.

> iOS Plugins: Cordova-iOS 4.0.0 compatibility
> --------------------------------------------
>
>                 Key: CB-8659
>                 URL: https://issues.apache.org/jira/browse/CB-8659
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: iOS, Plugin Battery Status, Plugin Camera, Plugin Contacts, Plugin
Device Orientation, Plugin Dialogs, Plugin File, Plugin Geolocation, Plugin Globalization,
Plugin InAppBrowser, Plugin Media, Plugin Media Capture
>    Affects Versions: 4.0.0
>            Reporter: Ian Clelland
>            Assignee: Ian Clelland
>             Fix For: 4.0.0
>
>
> iOS Plugins need to stop using initWithWebView:
> They also depend on several deprecated categories:
>   - NSArray+Comparisons.h
>   - NSDictionary+Extensions.h
> These need to be fixed in a backwards-compatible way before 4.0.0 is released.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message