cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-8635) InAppBrowser on Windows adds 40px gray border, wrapper div without class or id
Date Thu, 26 Mar 2015 07:06:53 GMT

    [ https://issues.apache.org/jira/browse/CB-8635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14381481#comment-14381481
] 

ASF GitHub Bot commented on CB-8635:
------------------------------------

GitHub user vladimir-kotikov opened a pull request:

    https://github.com/apache/cordova-plugin-inappbrowser/pull/98

    CB-8635 Improves UX on windows platform

    This implements some improvements for IAB on window from CB-8635
    
    - Adds `fullscreen` option which allows to open IAB window without gray border around
it
    - Adds ability to apply custom styles to IAB window via `inAppBrowserWrap` CSS class (similar
to Friefox OS)
    - Moves styles for IAB container to separate CSS file

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/MSOpenTech/cordova-plugin-inappbrowser CB-8635

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-inappbrowser/pull/98.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #98
    
----
commit c541fcf642a47a3ac235cfd26024b73db82c6358
Author: Vladimir Kotikov <v-vlkoti@microsoft.com>
Date:   2015-03-25T12:03:30Z

    CB-8635 Improves UX on windows platform
    
    * Adds `fullscreen` option
    * Adds ability to apply custom styles to IAB window

----


> InAppBrowser on Windows adds 40px gray border, wrapper div without class or id
> ------------------------------------------------------------------------------
>
>                 Key: CB-8635
>                 URL: https://issues.apache.org/jira/browse/CB-8635
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: Plugin InAppBrowser
>    Affects Versions: 3.6.0
>         Environment: Windows 8.1, Windows Phone 8.1
>            Reporter: Brandon Paddock
>
> The InAppBrowserProxy on Windows 8.1 does some weird things. One of them is that it adds
a wrapper div with a bunch of inline styles on it, including a gray 40px border on all sides.
This appears even if you set the "location=no" option to disable the default browser controls.
> Because this div is inserted directly under the body element with no id or class, you
can't override its styling via CSS (and since it uses inline styles, you'd have to use !important
to override them).
> Suggested fixes:
> 1) Assign a class name to the div so it can be styled.
> 2) Don't use an inline style for the default styling. Use CSS.
> 3) Don't put this weird gray border in the default styling (it isn't there on Android
so why put it there on Windows?)
> 4) Or, remove the div entirely (at least in the location=no case).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message