cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-8595) Merge platform specific code into one place
Date Wed, 11 Mar 2015 14:19:39 GMT

    [ https://issues.apache.org/jira/browse/CB-8595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14356919#comment-14356919
] 

ASF GitHub Bot commented on CB-8595:
------------------------------------

Github user mmocny commented on a diff in the pull request:

    https://github.com/apache/cordova-lib/pull/183#discussion_r26215219
  
    --- Diff: cordova-lib/src/plugman/uninstall.js ---
    @@ -293,58 +293,25 @@ function runUninstallPlatform(actions, platform, project_dir, plugin_dir,
plugin
     function handleUninstall(actions, platform, pluginInfo, project_dir, www_dir, plugins_dir,
is_top_level, options) {
         var plugin_id = pluginInfo.id;
         var plugin_dir = pluginInfo.dir;
    -    var platform_modules = require('./platforms');
    -    var handler = platform_modules[platform];
    -    www_dir = www_dir || handler.www_dir(project_dir);
    +    var handler = platform_modules.getPlatformProject(platform, project_dir);
    +    www_dir = www_dir || handler.www_dir();
         events.emit('log', 'Uninstalling ' + plugin_id + ' from ' + platform);
     
    +    var pluginItems = pluginInfo.getFilesAndFrameworks(platform);
         var assets = pluginInfo.getAssets(platform);
    --- End diff --
    
    Why are assets different?


> Merge platform specific code into one place
> -------------------------------------------
>
>                 Key: CB-8595
>                 URL: https://issues.apache.org/jira/browse/CB-8595
>             Project: Apache Cordova
>          Issue Type: Improvement
>            Reporter: Mark Koudritsky
>            Assignee: Mark Koudritsky
>
> Currently we have two separate places for platform specific code
> src/cordova/metadata
> src/plugman/platforms
> This is confusing.
> Once consolidated the platform specific code will be much easier to move to the platform
repos where it belongs.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message