cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-8580) PluginResult.Status.NO_RESULT is broken (error CB is invoked instead)
Date Tue, 03 Mar 2015 08:02:05 GMT

    [ https://issues.apache.org/jira/browse/CB-8580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14344704#comment-14344704
] 

ASF GitHub Bot commented on CB-8580:
------------------------------------

Github user EddyVerbruggen closed the pull request at:

    https://github.com/apache/cordova-wp8/pull/77


> PluginResult.Status.NO_RESULT is broken (error CB is invoked instead)
> ---------------------------------------------------------------------
>
>                 Key: CB-8580
>                 URL: https://issues.apache.org/jira/browse/CB-8580
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: WP8
>    Affects Versions: 3.7.0
>            Reporter: Eddy Verbruggen
>            Assignee: Jesse MacFadyen
>
> Before 3.7.0 a plugin could respond with:
> PluginResult pluginResult = new PluginResult(PluginResult.Status.NO_RESULT);
> pluginResult.KeepCallback = true;
> this.DispatchCommandResult(pluginResult);
> This meant the successCB nor the errorCB was invoked awaiting a further response from
native code.
> Since 3.7.0 however in this case the errorCB is invoked due to this difference:
> Before 3.7.0: https://github.com/apache/cordova-wp8/blob/3.5.x/common/www/cordova.js#L293
> Since 3.7.0: https://github.com/apache/cordova-wp8/blob/3.7.1/template/www/cordova.js#L287
> I'd love to see the old behavior in a future release.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message