cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-8577) 'cordova plugin add <plugin> --save' should save variables into config.xml
Date Mon, 02 Mar 2015 00:31:04 GMT

    [ https://issues.apache.org/jira/browse/CB-8577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14342564#comment-14342564
] 

ASF GitHub Bot commented on CB-8577:
------------------------------------

Github user omefire commented on the pull request:

    https://github.com/apache/cordova-lib/pull/174#issuecomment-76641117
  
    Fixing it in Config.getFeature(id) would mean that we would have to differentiate between
`<param>` types : variables and non-variables. I think that could be unecessarily complex,
require special logic and create more subtle bugs. So, I'm in favor on fixing the syntax itself.


> 'cordova plugin add <plugin> --save' should save variables into config.xml
> --------------------------------------------------------------------------
>
>                 Key: CB-8577
>                 URL: https://issues.apache.org/jira/browse/CB-8577
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: CordovaLib
>            Reporter: Omar Mefire
>
> When adding a plugin with the --save/autosave option on, the variables (if any is passed)
should be saved into config.xml so that the plugin can be auto-restored successfully later
during 'prepare' or 'build' operation.
> For example:
> - cordova create hello com.omefire.hello Hello
> - cd hello
> - cordova plugin add com.phonegap.plugins.facebookconnect --variable APP_ID="my-app-id"
--variable APP_NAME="my-app-name" --save => results in facebook plugin added to config.xml
> - cordova prepare android => results in an error message :
> " Installing "com.phonegap.plugins.facebookconnect" for android
> Failed to install 'com.phonegap.plugins.facebookconnect':Error: Variable(s) missing:
APP_ID, APP_NAME "
> This issue is due to the fact that 'cordova plugin add <plugin> --save' save variables
in config.xml using the <param> tag instead of the <variable> tag.
> N.B: on 'cordova prepare <platform>', the plugins are restored from config.xml
if they are not yet installed.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message