cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-8551) Setup fetching from npm as fallback
Date Tue, 03 Mar 2015 23:10:04 GMT

    [ https://issues.apache.org/jira/browse/CB-8551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14345964#comment-14345964
] 

ASF GitHub Bot commented on CB-8551:
------------------------------------

Github user jsoref commented on a diff in the pull request:

    https://github.com/apache/cordova-lib/pull/175#discussion_r25737449
  
    --- Diff: cordova-lib/src/plugman/registry/registry.js ---
    @@ -236,15 +231,22 @@ function initSettings() {
         module.exports.settings =
         rc('plugman', {
             cache: plugmanCacheDir,
    -        registry: 'http://registry.cordova.io',
    +        registry: registryURL,
             logstream: fs.createWriteStream(path.resolve(plugmanConfigDir, 'plugman.log')),
             userconfig: path.resolve(plugmanConfigDir, 'config'),
             'cache-min': oneDay
         });
    +
    +    // if npm is true, use npm registry. 
    +    // ~/.plugman/config overides the above config if it exists. 
    +    // Need to reset the registry value in settings 
    +    if(npm) {
    +        settings.registry = 'http://registry.npmjs.org';
    --- End diff --
    
    fwiw, I'm +1 for not duplicating strings. I tend to lose a lot of time having to adjust
things...


> Setup fetching from npm as fallback
> -----------------------------------
>
>                 Key: CB-8551
>                 URL: https://issues.apache.org/jira/browse/CB-8551
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: CordovaLib
>            Reporter: Steve Gill
>            Assignee: Steve Gill
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message