cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-8551) Setup fetching from npm as fallback
Date Tue, 03 Mar 2015 17:52:04 GMT

    [ https://issues.apache.org/jira/browse/CB-8551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14345403#comment-14345403
] 

ASF GitHub Bot commented on CB-8551:
------------------------------------

Github user mmocny commented on a diff in the pull request:

    https://github.com/apache/cordova-lib/pull/175#discussion_r25709035
  
    --- Diff: cordova-lib/src/cordova/plugin.js ---
    @@ -238,7 +239,21 @@ module.exports = function plugin(command, targets, opts) {
                     return opts.plugins.reduce(function(soFar, target) {
                         // Check if we have the plugin.
                         if (plugins.indexOf(target) < 0) {
    -                        return Q.reject(new CordovaError('Plugin "' + target + '" is
not present in the project. See `'+cordova_util.binname+' plugin list`.'));
    +                        // Convert target from package-name to package-id if necessary
    +                        var keys = Object.keys(pluginMapper);
    +                        //Traverse through pluginMapper values to see if it equals our
target.
    +                        //Cordova-plugin-device would get changes to org.apache.cordova.device
    +                        for (var i = 0; i < keys.length; i++) {
    --- End diff --
    
    I don't know why we are iterating anyway?  Its already old_id->new_id.  Can't we just
`.hasOwnProperty()` ?


> Setup fetching from npm as fallback
> -----------------------------------
>
>                 Key: CB-8551
>                 URL: https://issues.apache.org/jira/browse/CB-8551
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: CordovaLib
>            Reporter: Steve Gill
>            Assignee: Steve Gill
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message