cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-8521) 'cordova plugin save' should save all installed plugins and their version/git-url/folder-location into config.xml
Date Thu, 12 Mar 2015 08:23:39 GMT

    [ https://issues.apache.org/jira/browse/CB-8521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14358283#comment-14358283
] 

ASF GitHub Bot commented on CB-8521:
------------------------------------

Github user vladimir-kotikov commented on a diff in the pull request:

    https://github.com/apache/cordova-lib/pull/178#discussion_r26284601
  
    --- Diff: cordova-lib/src/cordova/plugin.js ---
    @@ -278,9 +283,16 @@ module.exports = function plugin(command, targets, opts) {
                                     events.emit('results', 'config.xml entry for ' +target+
' is removed');
                                 }
                             }
    +                    })
    +                    .then(function(){
    +                        // Remove plugin from fetch.json
    +                        events.emit('verbose', 'Removing plugin ' + target + ' from fetch.json');
    +                        var pluginsDir = path.join(projectRoot, 'plugins');
    +                        metadata.remove_plugin(pluginsDir, target);
                         });
                     }, Q());
    -            }).then(function() {
    +            })
    +            .then(function() {
    --- End diff --
    
    Unnecessary change


> 'cordova plugin save' should save all installed plugins and their version/git-url/folder-location
into config.xml
> -----------------------------------------------------------------------------------------------------------------
>
>                 Key: CB-8521
>                 URL: https://issues.apache.org/jira/browse/CB-8521
>             Project: Apache Cordova
>          Issue Type: New Feature
>            Reporter: Omar Mefire
>            Assignee: Omar Mefire
>
> In addition to using 'cordova plugin add org.apache.cordova.device --save' to both add
and save a plugin to config.xml, It would be useful to have a way to 'mass save' already installed
plugins to config.xml.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message