cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-8484) Cordova package support for Android
Date Mon, 30 Mar 2015 18:29:53 GMT

    [ https://issues.apache.org/jira/browse/CB-8484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14387149#comment-14387149
] 

ASF GitHub Bot commented on CB-8484:
------------------------------------

Github user nikhilkh commented on a diff in the pull request:

    https://github.com/apache/cordova-android/pull/164#discussion_r27418136
  
    --- Diff: bin/templates/cordova/lib/build.js ---
    @@ -409,7 +442,29 @@ function parseOpts(options, resolvedTarget) {
                 console.warn('Build option \'' + options[i] + '\' not recognized (ignoring).');
             }
         }
    +    if (packageArgs.keystore && packageArgs.alias) {
    +        var keystore = path.relative(ROOT, path.resolve(packageArgs.keystore));
    +        ret.packageInfo = new PackageInfo(keystore, packageArgs.alias, packageArgs.keystorePassword,
    +            packageArgs.password, packageArgs.keystoreType);
    +    } else if (fs.existsSync(path.join(CORDOVAROOT, BUILD_CONFIG_FILE))) {
    --- End diff --
    
    I did not realize that this was the design all along - of not looking into parent directories.
I like your idea of passing the path to the JSON file as a single argument. I'm less inclined
to do others:
    1. 'codova prepare' creating -singing.properties file: There will require a lot of platform
specific logic being in cordova-lib and less than ideal.
    2. Pass multiple command line parameters: Escaping complex arguments correctly on command
line might be tricky and messy.
    
    From what I can understand, this results in two changes:
    1. cordova-lib to pass path to build.json. Perhaps find a way to version this change -
so that older versions of the platforms do not see this unexpected arg.
    2. Android build script consuming this build.json and reading the `android` section of
it.


> Cordova package support for Android
> -----------------------------------
>
>                 Key: CB-8484
>                 URL: https://issues.apache.org/jira/browse/CB-8484
>             Project: Apache Cordova
>          Issue Type: Sub-task
>          Components: Android
>    Affects Versions: 4.0.0
>            Reporter: Nikhil Khandelwal
>            Assignee: Nikhil Khandelwal
>
> Details of the design here:
> https://docs.google.com/document/d/1tJQ9OoGrrMhZcLI3mg46rGzAfbiQu9PuNBL1auAMGFM/edit#



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message