cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-8351) Remove un-prefixed class extensions from public cordova-ios interface
Date Mon, 30 Mar 2015 18:15:54 GMT

    [ https://issues.apache.org/jira/browse/CB-8351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14387122#comment-14387122
] 

ASF GitHub Bot commented on CB-8351:
------------------------------------

GitHub user gconnolly opened a pull request:

    https://github.com/apache/cordova-plugin-camera/pull/79

    Fix custom implementation of integerValueForKey

    Related to CB-8351
    Commit: https://github.com/apache/cordova-plugin-camera/commit/2ead6335c92deb117cc3ef84d0a15db296de8dc5
    
    as suggested by @PiotrPiesiak. I have encountered the same issue.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/gconnolly/cordova-plugin-camera patch-1

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-camera/pull/79.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #79
    
----
commit c9f0465f52f77cd0f91f3380c962063915f5ee9b
Author: Gene Connolly <connolly.gene@gmail.com>
Date:   2015-03-30T18:13:50Z

    Fix custom implementation of integerValueForKey
    
    Related to CB-8351
    https://github.com/apache/cordova-plugin-camera/commit/2ead6335c92deb117cc3ef84d0a15db296de8dc5#diff-3cfd0e1f93894bd4e501e8e0e4634850

----


> Remove un-prefixed class extensions from public cordova-ios interface
> ---------------------------------------------------------------------
>
>                 Key: CB-8351
>                 URL: https://issues.apache.org/jira/browse/CB-8351
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: iOS
>            Reporter: Andrew Grieve
>            Assignee: Andrew Grieve
>            Priority: Minor
>
> Related to CB-8270, there are other non-prefixed class extensions that exists within
CordovaLib. Most of them are really even useful anymore, but are used by some of our plugins.
We should update the plugins to not need them, and then deprecated the symbols. Removing them
in 4.0.0 might be too aggressive though?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message