cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Shazron Abdullah (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (CB-7767) [iOS] Remove usage of NSData+Base64
Date Tue, 17 Mar 2015 08:46:38 GMT

     [ https://issues.apache.org/jira/browse/CB-7767?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Shazron Abdullah updated CB-7767:
---------------------------------
    Description: 
There is built in support since iOS 7. Once we drop iOS 6, we can do this.

https://developer.apple.com/library/ios/documentation/Cocoa/Reference/Foundation/Classes/NSData_Class/index.html#//apple_ref/doc/uid/20000172-SW36

Lines:
1. https://github.com/apache/cordova-ios/blob/1a44a4eed9f22024cc0480733a4c21af63f92ab5/CordovaLib/Classes/CDVInvokedUrlCommand.m#L88
2. https://github.com/apache/cordova-ios/blob/1a44a4eed9f22024cc0480733a4c21af63f92ab5/CordovaLib/Classes/CDVPluginResult.m#L40

Replace with:
1. [[NSData alloc] initWithBase64EncodedString:data options:0]
2. [data base64EncodedStringWithOptions:0]

Test mobilespec bridge benchmark before this change and after, then report the results. 

  was:
There is built in support since iOS 7. Once we drop iOS 6, we can do this.

https://developer.apple.com/library/ios/documentation/Cocoa/Reference/Foundation/Classes/NSData_Class/index.html#//apple_ref/doc/uid/20000172-SW36

Lines:
1. https://github.com/apache/cordova-ios/blob/1a44a4eed9f22024cc0480733a4c21af63f92ab5/CordovaLib/Classes/CDVInvokedUrlCommand.m#L88
2. https://github.com/apache/cordova-ios/blob/1a44a4eed9f22024cc0480733a4c21af63f92ab5/CordovaLib/Classes/CDVPluginResult.m#L40

Replace with:
1. [[NSData alloc] initWithBase64EncodedString:data options:0]
2. [data base64EncodedStringWithOptions:0]



> [iOS] Remove usage of NSData+Base64 
> ------------------------------------
>
>                 Key: CB-7767
>                 URL: https://issues.apache.org/jira/browse/CB-7767
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: iOS
>            Reporter: Shazron Abdullah
>             Fix For: 4.0.0
>
>
> There is built in support since iOS 7. Once we drop iOS 6, we can do this.
> https://developer.apple.com/library/ios/documentation/Cocoa/Reference/Foundation/Classes/NSData_Class/index.html#//apple_ref/doc/uid/20000172-SW36
> Lines:
> 1. https://github.com/apache/cordova-ios/blob/1a44a4eed9f22024cc0480733a4c21af63f92ab5/CordovaLib/Classes/CDVInvokedUrlCommand.m#L88
> 2. https://github.com/apache/cordova-ios/blob/1a44a4eed9f22024cc0480733a4c21af63f92ab5/CordovaLib/Classes/CDVPluginResult.m#L40
> Replace with:
> 1. [[NSData alloc] initWithBase64EncodedString:data options:0]
> 2. [data base64EncodedStringWithOptions:0]
> Test mobilespec bridge benchmark before this change and after, then report the results.




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message