cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-7698) CLI: no validation for globally required plugin variables
Date Fri, 13 Mar 2015 15:04:38 GMT

    [ https://issues.apache.org/jira/browse/CB-7698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14360470#comment-14360470
] 

ASF GitHub Bot commented on CB-7698:
------------------------------------

Github user vladimir-kotikov commented on a diff in the pull request:

    https://github.com/apache/cordova-lib/pull/184#discussion_r26392721
  
    --- Diff: cordova-lib/src/cordova/plugin.js ---
    @@ -185,8 +185,9 @@ module.exports = function plugin(command, targets, opts) {
                                 });
                             if (missingVariables.length) {
                                 shell.rm('-rf', dir);
    -                            events.emit('results', 'Variable(s) missing (use: --variable
' + missingVariables.join('=value --variable ') + '=value).');
    -                            return;
    +                            var msg = 'Variable(s) missing (use: --variable ' + missingVariables.join('=value
--variable ') + '=value).';
    +                            events.emit('results', msg);
    --- End diff --
    
    There is no need to emit the results event to log error message to console. There is a
an error handler in cordova-cli which does this already.


> CLI: no validation for globally required plugin variables
> ---------------------------------------------------------
>
>                 Key: CB-7698
>                 URL: https://issues.apache.org/jira/browse/CB-7698
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: CLI
>            Reporter: Bryan Higgins
>            Assignee: Bryan Higgins
>            Priority: Minor
>
> CLI should check that any globally required variables (preference at root level in plugin.xml)
have been provided before calling plugman.install on the platforms. Otherwise the plugin is
added to the project but plugman fails to install to any platforms.
> From the docs:
> plugman checks that these required preferences are passed in. If not, it should warn
the user how to pass the variable in and exit with a non-zero code.
> http://cordova.apache.org/docs/en/3.6.0/plugin_ref_spec.md.html#Plugin%20Specification



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message