cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-5806) [Windows8] Add keepCallback support to proxy
Date Thu, 12 Mar 2015 06:17:39 GMT

    [ https://issues.apache.org/jira/browse/CB-5806?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14358152#comment-14358152
] 

ASF GitHub Bot commented on CB-5806:
------------------------------------

Github user CJRChang commented on a diff in the pull request:

    https://github.com/apache/cordova-windows/pull/61#discussion_r26280804
  
    --- Diff: cordova-js-src/exec.js ---
    @@ -60,18 +60,32 @@ module.exports = function (success, fail, service, action, args) {
                 // CB-5806 [Windows8] Add keepCallback support to proxy
                 onSuccess = function (result, callbackOptions) {
                     callbackOptions = callbackOptions || {};
    +                var callbackStatus;
    +                if (callbackOptions.status !== null) {
    --- End diff --
    
    Yes it is - in the event that the user passes a callbackOptions but does not specify status,
it will return null.


> [Windows8] Add keepCallback support to proxy
> --------------------------------------------
>
>                 Key: CB-5806
>                 URL: https://issues.apache.org/jira/browse/CB-5806
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: CordovaJS, Windows 8
>    Affects Versions: 3.3.0
>            Reporter: Sergey Grebnov
>            Assignee: Jesse MacFadyen
>             Fix For: 3.4.0
>
>
> Below is current proxy implementation. There is no way pass keepCallbck param via onSuccess
method.
>             onSuccess = function (result) {
>                 cordova.callbackSuccess(callbackId,
>                         {
>                         status: cordova.callbackStatus.OK,
>                         message: result
>                     });
>             };
>             onError = function (err) {
>                 cordova.callbackError(callbackId,
>                         {
>                         status: cordova.callbackStatus.ERROR,
>                         message: err
>                     });
>             };
>             proxy(onSuccess, onError, args);



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message