Return-Path: X-Original-To: apmail-cordova-issues-archive@minotaur.apache.org Delivered-To: apmail-cordova-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 71E0617F03 for ; Thu, 5 Feb 2015 20:15:36 +0000 (UTC) Received: (qmail 69643 invoked by uid 500); 5 Feb 2015 20:15:36 -0000 Delivered-To: apmail-cordova-issues-archive@cordova.apache.org Received: (qmail 69628 invoked by uid 500); 5 Feb 2015 20:15:36 -0000 Mailing-List: contact issues-help@cordova.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@cordova.apache.org Received: (qmail 69574 invoked by uid 99); 5 Feb 2015 20:15:36 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 05 Feb 2015 20:15:36 +0000 Date: Thu, 5 Feb 2015 20:15:35 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: issues@cordova.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (CB-8412) WP8 platform should use JSHint as part of npm test MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/CB-8412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14307908#comment-14307908 ] ASF GitHub Bot commented on CB-8412: ------------------------------------ GitHub user muratsu opened a pull request: https://github.com/apache/cordova-ios/pull/129 CB-8412 enable jshint for iOS platform - Created a npm run jshint command & integrate into npm run test - Created jshint rules files for spec and rest of the repo - Fixed all jshint issues You can merge this pull request into a Git repository by running: $ git pull https://github.com/MSOpenTech/cordova-ios CB-8412 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-ios/pull/129.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #129 ---- commit cad69d1cd68115cd6a31ae28eeaef288d760b3b3 Author: Murat Sutunc Date: 2015-02-05T20:03:37Z CB-8412 Enable jshint for iOS platform commit 1f66085883014e837d26eef07180d3085232cce9 Author: Murat Sutunc Date: 2015-02-05T20:13:22Z CB-8412 fix all jshint issues for iOS ---- > WP8 platform should use JSHint as part of npm test > -------------------------------------------------- > > Key: CB-8412 > URL: https://issues.apache.org/jira/browse/CB-8412 > Project: Apache Cordova > Issue Type: Improvement > Components: WP8 > Reporter: Murat Sutunc > Assignee: Jesse MacFadyen > Priority: Minor > > WP8 platform should use jshint as part of tests. This should also be part of travis automation -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org For additional commands, e-mail: issues-help@cordova.apache.org