Return-Path: X-Original-To: apmail-cordova-issues-archive@minotaur.apache.org Delivered-To: apmail-cordova-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 333DB17806 for ; Thu, 5 Feb 2015 17:45:35 +0000 (UTC) Received: (qmail 63172 invoked by uid 500); 5 Feb 2015 17:45:35 -0000 Delivered-To: apmail-cordova-issues-archive@cordova.apache.org Received: (qmail 63153 invoked by uid 500); 5 Feb 2015 17:45:35 -0000 Mailing-List: contact issues-help@cordova.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@cordova.apache.org Received: (qmail 63137 invoked by uid 99); 5 Feb 2015 17:45:34 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 05 Feb 2015 17:45:34 +0000 Date: Thu, 5 Feb 2015 17:45:34 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: issues@cordova.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (CB-8227) Add --save option to 'cordova platform add' MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/CB-8227?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14307632#comment-14307632 ] ASF GitHub Bot commented on CB-8227: ------------------------------------ Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-lib/pull/144#issuecomment-73091506 The fact that the tests cannot run in the allotted 40 minutes means there is an error in the tests. I would dump all the jshintrc related commits into another pr. Also, I'm not crazy about the whole single quote to double quote thing. jshintrc wasn't even complaining about it. > Add --save option to 'cordova platform add' > ------------------------------------------- > > Key: CB-8227 > URL: https://issues.apache.org/jira/browse/CB-8227 > Project: Apache Cordova > Issue Type: New Feature > Components: CLI, CordovaLib > Reporter: Omar Mefire > Original Estimate: 48h > Remaining Estimate: 48h > > When run with the --save flag, the 'platform add' command will not only add the specified platforms, but it will also save them to config.xml. > - When running this command, the pinned CLI version will be used if no version is specified. > - config.xml will be ovewritten if similar engine has already been specified in config.xml -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org For additional commands, e-mail: issues-help@cordova.apache.org